Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2557733004: [Sync] Add histogram for events in ClearServerData flow. (Closed)

Created:
4 years ago by pavely
Modified:
4 years ago
Reviewers:
Nicolas Zea, jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Add histogram for events in ClearServerData flow. I'm adding histogram for different events during ClearServerData flow. They'll help monitor how often enabpling passphrase encryption encounters issues. R=zea@chromium.org,jwd@chromium.org BUG=490836 Committed: https://crrev.com/e3f89a3d3785c27d47b884f0c9f0a463adc0e812 Cr-Commit-Position: refs/heads/master@{#437678}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -7 lines) Patch
M components/browser_sync/profile_sync_service.cc View 1 8 chunks +43 lines, -6 lines 0 comments Download
M components/sync/engine_impl/sync_scheduler_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
pavely
4 years ago (2016-12-07 01:06:38 UTC) #5
Nicolas Zea
lgtm https://codereview.chromium.org/2557733004/diff/1/components/browser_sync/profile_sync_service.cc File components/browser_sync/profile_sync_service.cc (right): https://codereview.chromium.org/2557733004/diff/1/components/browser_sync/profile_sync_service.cc#newcode122 components/browser_sync/profile_sync_service.cc:122: // Events in ClearServerData flow to be recorded ...
4 years ago (2016-12-07 21:00:21 UTC) #8
pavely
https://codereview.chromium.org/2557733004/diff/1/components/browser_sync/profile_sync_service.cc File components/browser_sync/profile_sync_service.cc (right): https://codereview.chromium.org/2557733004/diff/1/components/browser_sync/profile_sync_service.cc#newcode122 components/browser_sync/profile_sync_service.cc:122: // Events in ClearServerData flow to be recorded in ...
4 years ago (2016-12-07 22:05:28 UTC) #9
jwd
lgtm
4 years ago (2016-12-09 20:04:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557733004/20001
4 years ago (2016-12-09 20:18:59 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 23:00:44 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-12 14:57:14 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e3f89a3d3785c27d47b884f0c9f0a463adc0e812
Cr-Commit-Position: refs/heads/master@{#437678}

Powered by Google App Engine
This is Rietveld 408576698