Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3499)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js

Issue 2557713003: Don't consider large static text nodes as objects (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js
index 238980fdf89e3cf4b32dc789893b7342ee3ad4a8..af8cefa3b8bcdd922271d1485a6ee73270fefae4 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js
@@ -19,3 +19,18 @@ constants.Dir = {
/** Search from right to left. */
BACKWARD: 'backward'
};
+
+/**
+ * If a node contains more characters than this, it should not be treated
+ * as a leaf node.
+ *
+ * This number was determined by looking at the average number of
+ * characters in a paragraph:
+ * http://www.fullondesign.co.uk/design/usability/
dmazzoni 2016/12/07 06:40:51 This link doesn't work for me. I tried appending t
David Tseng 2016/12/07 17:11:30 Removed.
+ * 285-how-many-characters-per-a-page-is-normal.htm
+ * and then trying it out on a few popular websites (CNN, BBC,
+ * Google Search, etc.) and making sure it made sense.
+ * @type {number}
+ * @const
+ */
+constants.MAX_CHARCOUNT = 1500;
dmazzoni 2016/12/07 06:40:50 How about constants.LEAF_MAX_CHARCOUNT just so it'
David Tseng 2016/12/07 17:11:30 This was taken pretty much verbatim from group uti
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698