chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js - Issue 2557713003: Don't consider large static text nodes as objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

Issue 2557713003: Don't consider large static text nodes as objects (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js » ('j') | chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

index 098ea678ecf0dad4f5d8af0fb73e2b58b115dcef..501346de12c6ef60c1cf0e6efe7467684240d9a5 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

@@ -225,6 +225,7 @@ AutomationPredicate.object = function(node) {

return node.state.focusable ||

(AutomationPredicate.leafOrStaticText(node) &&

+ (!node.name || node.name.length < constants.MAX_CHARCOUNT) &&

(/\S+/.test(node.name) ||

(node.role != Role.lineBreak &&

node.role != Role.staticText &&