content::ReloadType cleanup: make NORMAL behave as MAIN_RESOURCE

content::ReloadType cleanup: make NORMAL behave as MAIN_RESOURCE

Now that ReloadType::MAIN_RESOURCE is default reload behavior and
we do not need to use ReloadType::NORMAL any more, let's make
ReloadType::NORMAL behavior same with one of ReloadType::MAIN_RESOURCE.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/b0d4eed34b7a81eba62fa16f0e7e984cb587ad21
Cr-Commit-Position: refs/heads/master@{#437481}

[Takashi Toyoshima, 2016-12-06 07:42:34]

Description was changed from

==========
content::ReloadType cleanup: make NORMAL behave as MAIN_RESOURCE

Now that ReloadType::MAIN_RESOURCE is default reload behavior and
we do not need to use ReloadType::NORMAL any more, let's make
ReloadType::NORMAL behavior same with one of ReloadType::MAIN_RESOURCE.

BUG=670232
==========

to

==========
content::ReloadType cleanup: make NORMAL behave as MAIN_RESOURCE

Now that ReloadType::MAIN_RESOURCE is default reload behavior and
we do not need to use ReloadType::NORMAL any more, let's make
ReloadType::NORMAL behavior same with one of ReloadType::MAIN_RESOURCE.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2016-12-06 07:42:41]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 07:43:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2016-12-06 07:44:36]

Description was changed from

==========
content::ReloadType cleanup: make NORMAL behave as MAIN_RESOURCE

Now that ReloadType::MAIN_RESOURCE is default reload behavior and
we do not need to use ReloadType::NORMAL any more, let's make
ReloadType::NORMAL behavior same with one of ReloadType::MAIN_RESOURCE.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
content::ReloadType cleanup: make NORMAL behave as MAIN_RESOURCE

Now that ReloadType::MAIN_RESOURCE is default reload behavior and
we do not need to use ReloadType::NORMAL any more, let's make
ReloadType::NORMAL behavior same with one of ReloadType::MAIN_RESOURCE.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2016-12-06 07:44:36]

toyoshim@chromium.org changed reviewers:
+ creis@chromium.org

[Takashi Toyoshima, 2016-12-06 07:46:35]

Before merging Reload*() to one Reload() with ReloadType, can I remove
ReloadType::MAIN_RESOURCE and make ReloadType::NORMAL behave as the current
ReloadType::MAIN_RESOURCE? I want to submit this before the Reload* merge change
because I do not want to expose old type reload of ReloadType::NORMAL.

[commit-bot: I haz the power, 2016-12-06 09:02:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 09:02:42]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2016-12-08 23:46:11]

The old ReloadType::NORMAL is unused at the moment, right?  I'm ok with
effectively renaming MAIN_RESOURCE to NORMAL now that the experiments are over. 
LGTM.

https://codereview.chromium.org/2557633003/diff/1/content/common/frame_messag...
File content/common/frame_message_enums.h (right):

https://codereview.chromium.org/2557633003/diff/1/content/common/frame_messag...
content/common/frame_message_enums.h:18: // compatible with
RELOAD_MAIN_RESOURCE.
I'd suggest rephrasing this to say that we should rename this one to be RELOAD
(and remove the old unused RELOAD behavior).

[Takashi Toyoshima, 2016-12-09 04:40:31]

https://codereview.chromium.org/2557633003/diff/1/content/common/frame_messag...
File content/common/frame_message_enums.h (right):

https://codereview.chromium.org/2557633003/diff/1/content/common/frame_messag...
content/common/frame_message_enums.h:18: // compatible with
RELOAD_MAIN_RESOURCE.
On 2016/12/08 23:46:11, Charlie Reis wrote:
> I'd suggest rephrasing this to say that we should rename this one to be RELOAD
> (and remove the old unused RELOAD behavior).

Done.

[Takashi Toyoshima, 2016-12-09 04:40:35]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-12-09 04:40:35]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2557633003/#ps20001
(title: "comment update")

[commit-bot: I haz the power, 2016-12-09 04:41:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 06:03:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481258435157280,
"parent_rev": "99a7cb5f319b647e859f8259069b57906bbb5eba", "commit_rev":
"fcc8ae27cce0a55d64344e65c2d396d8c34027bb"}

[commit-bot: I haz the power, 2016-12-09 06:03:36]

Description was changed from

==========
content::ReloadType cleanup: make NORMAL behave as MAIN_RESOURCE

Now that ReloadType::MAIN_RESOURCE is default reload behavior and
we do not need to use ReloadType::NORMAL any more, let's make
ReloadType::NORMAL behavior same with one of ReloadType::MAIN_RESOURCE.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
content::ReloadType cleanup: make NORMAL behave as MAIN_RESOURCE

Now that ReloadType::MAIN_RESOURCE is default reload behavior and
we do not need to use ReloadType::NORMAL any more, let's make
ReloadType::NORMAL behavior same with one of ReloadType::MAIN_RESOURCE.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-12-09 06:03:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-09 06:07:27]

Description was changed from

==========
content::ReloadType cleanup: make NORMAL behave as MAIN_RESOURCE

Now that ReloadType::MAIN_RESOURCE is default reload behavior and
we do not need to use ReloadType::NORMAL any more, let's make
ReloadType::NORMAL behavior same with one of ReloadType::MAIN_RESOURCE.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
content::ReloadType cleanup: make NORMAL behave as MAIN_RESOURCE

Now that ReloadType::MAIN_RESOURCE is default reload behavior and
we do not need to use ReloadType::NORMAL any more, let's make
ReloadType::NORMAL behavior same with one of ReloadType::MAIN_RESOURCE.

BUG=670232
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/b0d4eed34b7a81eba62fa16f0e7e984cb587ad21
Cr-Commit-Position: refs/heads/master@{#437481}
==========

[commit-bot: I haz the power, 2016-12-09 06:07:28]

Patchset 2 (id:??) landed as
https://crrev.com/b0d4eed34b7a81eba62fa16f0e7e984cb587ad21
Cr-Commit-Position: refs/heads/master@{#437481}