Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: content/browser/frame_host/navigation_controller_impl_browsertest.cc

Issue 2557633003: content::ReloadType cleanup: make NORMAL behave as MAIN_RESOURCE (Closed)
Patch Set: comment update Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl_browsertest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_browsertest.cc b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
index f079f7d1727362c8fcfa61d6a87b4aecea97c042..e8bf8796fc9c16098d4d6e80bdadfb5a42c34000 100644
--- a/content/browser/frame_host/navigation_controller_impl_browsertest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
@@ -6690,8 +6690,8 @@ IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
NavigationControllerImpl& controller = static_cast<NavigationControllerImpl&>(
shell()->web_contents()->GetController());
- // Reload triggers a reload of ReloadType::MAIN_RESOURCE. The first reload
- // should not be counted.
+ // Reload triggers a reload of ReloadType::NORMAL. The first reload should
+ // not be counted.
controller.Reload(false);
EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));
histogram.ExpectTotalCount(kReloadToReloadMetricName, 0);
@@ -6726,8 +6726,8 @@ IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
histogram.ExpectTotalCount(kReloadToReloadMetricName, 2);
histogram.ExpectTotalCount(kReloadMainResourceToReloadMetricName, 1);
- // Another reload of ReloadType::MAIN_RESOURCE should be counted by both
- // metrics again.
+ // Another reload of ReloadType::NORMAL should be counted by both metrics
+ // again.
controller.Reload(false);
EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));
histogram.ExpectTotalCount(kReloadToReloadMetricName, 3);
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.cc ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698