Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2557513008: Enable messages in asserts by default (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, Lasse Reichstein
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -93 lines) Patch
M pkg/analyzer/lib/error/error.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 9 chunks +18 lines, -20 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 3 chunks +2 lines, -27 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 2 chunks +1 line, -16 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 6 chunks +0 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Brian Wilkerson
4 years ago (2016-12-07 20:21:10 UTC) #2
scheglov
LGTM
4 years ago (2016-12-07 20:22:17 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as e22a2b4626fe11393991f99d554fd52e00bfc0cc (presubmit successful).
4 years ago (2016-12-07 20:23:05 UTC) #5
kevmoo
On 2016/12/07 20:23:05, Brian Wilkerson wrote: > Committed patchset #1 (id:1) manually as > e22a2b4626fe11393991f99d554fd52e00bfc0cc ...
4 years ago (2016-12-07 21:09:48 UTC) #6
Brian Wilkerson
> Which bug is this? There were three issues in the issue tracker that I ...
4 years ago (2016-12-07 21:13:49 UTC) #7
Lasse Reichstein Nielsen
4 years ago (2016-12-08 07:00:48 UTC) #8
Message was sent while issue was closed.
I think we should just have one entry in the changelog when all platforms are
enabled. Adding an entry just for the analyzer, and the rewriting it later when
dart2js and the VM are enabled, seems like unnecessary work.

Powered by Google App Engine
This is Rietveld 408576698