Enable messages in asserts by default

pkg/analyzer/lib/src/generated/engine.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.generated.engine;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analyzer/dart/ast/ast.dart';
@@ skipping 1087 matching lines @@
 
   /**
    * Return `true` if the parser is to parse asserts in the initializer list of
    * a constructor.
    */
   bool get enableAssertInitializer;
 
   /**
    * Return `true` to enable custom assert messages (DEP 37).
    */
+  @deprecated
   bool get enableAssertMessage;
 
   /**
    * Return `true` to if analysis is to enable async support.
    */
   @deprecated
   bool get enableAsync;
 
   /**
    * Return `true` to enable interface libraries (DEP 40).
@@ skipping 178 matching lines @@
 class AnalysisOptionsImpl implements AnalysisOptions {
   /**
    * DEPRECATED: The maximum number of sources for which data should be kept in
    * the cache.
    *
    * This constant no longer has any effect.
    */
   @deprecated
   static const int DEFAULT_CACHE_SIZE = 64;
 
-  static const int ENABLE_ASSERT_FLAG = 0x01;
-  static const int ENABLE_LAZY_ASSIGNMENT_OPERATORS = 0x02;
-  static const int ENABLE_STRICT_CALL_CHECKS_FLAG = 0x04;
-  static const int ENABLE_STRONG_MODE_FLAG = 0x08;
-  static const int ENABLE_STRONG_MODE_HINTS_FLAG = 0x10;
-  static const int ENABLE_SUPER_MIXINS_FLAG = 0x20;
+  static const int ENABLE_LAZY_ASSIGNMENT_OPERATORS = 0x01;
+  static const int ENABLE_STRICT_CALL_CHECKS_FLAG = 0x02;
+  static const int ENABLE_STRONG_MODE_FLAG = 0x04;
+  static const int ENABLE_STRONG_MODE_HINTS_FLAG = 0x08;
+  static const int ENABLE_SUPER_MIXINS_FLAG = 0x10;
 
   /**
    * The default list of non-nullable type names.
    */
   static const List<String> NONNULLABLE_TYPES = const <String>[];
 
   /**
    * A predicate indicating whether analysis is to parse and analyze function
    * bodies.
    */
   AnalyzeFunctionBodiesPredicate _analyzeFunctionBodiesPredicate =
       _analyzeAllFunctionBodies;
 
   @override
   @deprecated
   int cacheSize = 64;
 
   @override
   bool dart2jsHint = false;
 
   @override
   bool enableAssertInitializer = false;
 
   @override
-  bool enableAssertMessage = false;
-
-  @override
   bool enableLazyAssignmentOperators = false;
 
   @override
   bool enableStrictCallChecks = false;
 
   @override
   bool enableSuperMixins = false;
 
   @override
   bool enableTiming = false;
@@ skipping 98 matching lines @@
   AnalysisOptionsImpl();
 
   /**
    * Initialize a newly created set of analysis options to have the same values
    * as those in the given set of analysis [options].
    */
   AnalysisOptionsImpl.from(AnalysisOptions options) {
     analyzeFunctionBodiesPredicate = options.analyzeFunctionBodiesPredicate;
     dart2jsHint = options.dart2jsHint;
     enableAssertInitializer = options.enableAssertInitializer;
-    enableAssertMessage = options.enableAssertMessage;
     enableStrictCallChecks = options.enableStrictCallChecks;
     enableLazyAssignmentOperators = options.enableLazyAssignmentOperators;
     enableSuperMixins = options.enableSuperMixins;
     enableTiming = options.enableTiming;
     errorProcessors = options.errorProcessors;
     excludePatterns = options.excludePatterns;
     generateImplicitErrors = options.generateImplicitErrors;
     generateSdkErrors = options.generateSdkErrors;
     hint = options.hint;
     incremental = options.incremental;
@@ skipping 38 matching lines @@
   AnalyzeFunctionBodiesPredicate get analyzeFunctionBodiesPredicate =>
       _analyzeFunctionBodiesPredicate;
 
   set analyzeFunctionBodiesPredicate(AnalyzeFunctionBodiesPredicate value) {
     if (value == null) {
       throw new ArgumentError.notNull('analyzeFunctionBodiesPredicate');
     }
     _analyzeFunctionBodiesPredicate = value;
   }
 
+  @override
+  @deprecated
+  bool get enableAssertMessage => true;
+
+  @deprecated
+  void set enableAssertMessage(bool enable) {}
+
   @deprecated
   @override
   bool get enableAsync => true;
 
   @deprecated
   void set enableAsync(bool enable) {}
 
   /**
    * A flag indicating whether interface libraries are to be supported (DEP 40).
    */
@@ skipping 45 matching lines @@
   /**
    * Set the lint rules that are to be run in an analysis context if [lint]
    * returns `true`.
    */
   void set lintRules(List<Linter> rules) {
     _lintRules = rules;
   }
 
   @override
   List<int> encodeCrossContextOptions() {
-    int flags = (enableAssertMessage ? ENABLE_ASSERT_FLAG : 0) |
+    int flags =
         (enableLazyAssignmentOperators ? ENABLE_LAZY_ASSIGNMENT_OPERATORS : 0) |
-        (enableStrictCallChecks ? ENABLE_STRICT_CALL_CHECKS_FLAG : 0) |
-        (enableSuperMixins ? ENABLE_SUPER_MIXINS_FLAG : 0) |
-        (strongMode ? ENABLE_STRONG_MODE_FLAG : 0) |
-        (strongModeHints ? ENABLE_STRONG_MODE_HINTS_FLAG : 0);
+            (enableStrictCallChecks ? ENABLE_STRICT_CALL_CHECKS_FLAG : 0) |
+            (enableSuperMixins ? ENABLE_SUPER_MIXINS_FLAG : 0) |
+            (strongMode ? ENABLE_STRONG_MODE_FLAG : 0) |
+            (strongModeHints ? ENABLE_STRONG_MODE_HINTS_FLAG : 0);
     return <int>[flags, patchPlatform];
   }
 
   @override
   void resetToDefaults() {
     dart2jsHint = false;
     disableCacheFlushing = false;
     enableAssertInitializer = false;
-    enableAssertMessage = false;
     enableLazyAssignmentOperators = false;
     enableStrictCallChecks = false;
     enableSuperMixins = false;
     enableTiming = false;
     enableUriInPartOf = false;
     _errorProcessors = null;
     _excludePatterns = null;
     finerGrainedInvalidation = false;
     generateImplicitErrors = true;
     generateSdkErrors = false;
     hint = true;
     implicitCasts = true;
     implicitDynamic = true;
     incremental = false;
     incrementalApi = false;
     incrementalValidation = false;
     lint = false;
     _lintRules = null;
     nonnullableTypes = NONNULLABLE_TYPES;
     patchPlatform = 0;
     preserveComments = true;
     strongMode = false;
     strongModeHints = false;
     trackCacheDependencies = true;
   }
 
   @override
   void setCrossContextOptionsFrom(AnalysisOptions options) {
-    enableAssertMessage = options.enableAssertMessage;
     enableLazyAssignmentOperators = options.enableLazyAssignmentOperators;
     enableStrictCallChecks = options.enableStrictCallChecks;
     enableSuperMixins = options.enableSuperMixins;
     strongMode = options.strongMode;
     if (options is AnalysisOptionsImpl) {
       strongModeHints = options.strongModeHints;
     }
     patchPlatform = options.patchPlatform;
   }
 
   /**
    * Produce a human readable list of option names corresponding to the options
    * encoded in the given [encoding], presumably from invoking the method
    * [encodeCrossContextOptions].
    */
   static String decodeCrossContextOptions(List<int> encoding) {
     List<String> parts = [];
     int flags = encoding[0];
-    if (flags & ENABLE_ASSERT_FLAG > 0) {
-      parts.add('assert');
-    }
     if (flags & ENABLE_LAZY_ASSIGNMENT_OPERATORS > 0) {
       parts.add('lazyAssignmentOperators');
     }
     if (flags & ENABLE_STRICT_CALL_CHECKS_FLAG > 0) {
       parts.add('strictCallChecks');
     }
     if (flags & ENABLE_SUPER_MIXINS_FLAG > 0) {
       parts.add('superMixins');
     }
     if (flags & ENABLE_STRONG_MODE_FLAG > 0) {
@@ skipping 1183 matching lines @@
    */
   bool get wereSourcesAdded => _changeSet.addedSources.length > 0;
 
   /**
    * Return `true` if any sources were removed or deleted.
    */
   bool get wereSourcesRemoved =>
       _changeSet.removedSources.length > 0 ||
       _changeSet.removedContainers.length > 0;
 }