Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java

Issue 2557513007: ntp_tiles::metrics: Add rappor metrics for impression URLs per icon type. (Closed)
Patch Set: Rebased. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java b/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
index f317c4a0a17a1c6b0a29ae74eb8c5fb8563d81d0..20534c1b3937409d68005b16de37b3b94a0f9890 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
@@ -110,9 +110,10 @@ public class MostVisitedSites {
* tile that's currently showing.
* @param sources An array of values from NTPTileSource indicating the source of each tile
* that's currently showing.
+ * @param tileUrls An array of strings indicating the URL of each tile.
*/
- public void recordPageImpression(int[] tileTypes, int[] sources) {
- nativeRecordPageImpression(mNativeMostVisitedSitesBridge, tileTypes, sources);
+ public void recordPageImpression(int[] tileTypes, int[] sources, String[] tileUrls) {
+ nativeRecordPageImpression(mNativeMostVisitedSitesBridge, tileTypes, sources, tileUrls);
}
/**
@@ -131,8 +132,8 @@ public class MostVisitedSites {
private native void nativeAddOrRemoveBlacklistedUrl(
long nativeMostVisitedSitesBridge, String url,
boolean addUrl);
- private native void nativeRecordPageImpression(long nativeMostVisitedSitesBridge,
- int[] tileTypes, int[] sources);
+ private native void nativeRecordPageImpression(
+ long nativeMostVisitedSitesBridge, int[] tileTypes, int[] sources, String[] tileUrls);
private native void nativeRecordOpenedMostVisitedItem(
long nativeMostVisitedSitesBridge, int index, int tileType, int source);
}

Powered by Google App Engine
This is Rietveld 408576698