Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2502)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2557513007: ntp_tiles::metrics: Add rappor metrics for impression URLs per icon type. (Closed)
Patch Set: Rebased. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 03d8041849adfcd82aa3a75ed0e6372a803507af..84a61f8dd909fc9b2d104693249940503bace7a5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -637,13 +637,15 @@ public class NewTabPage
int tileTypes[] = new int[items.length];
int sources[] = new int[items.length];
+ String tileUrls[] = new String[items.length];
for (int i = 0; i < items.length; i++) {
tileTypes[i] = items[i].getTileType();
sources[i] = items[i].getSource();
+ tileUrls[i] = items[i].getUrl();
}
- mMostVisitedSites.recordPageImpression(tileTypes, sources);
+ mMostVisitedSites.recordPageImpression(tileTypes, sources, tileUrls);
if (isNtpOfflinePagesEnabled()) {
final int maxNumTiles = 12;
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698