chrome/browser/android/ntp/most_visited_sites_bridge.h - Issue 2557513007: ntp_tiles::metrics: Add rappor metrics for impression URLs per icon type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/ntp/most_visited_sites_bridge.h

Issue 2557513007: ntp_tiles::metrics: Add rappor metrics for impression URLs per icon type. (Closed)

Patch Set: Addressed comments. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/ntp/most_visited_sites_bridge.h

diff --git a/chrome/browser/android/ntp/most_visited_sites_bridge.h b/chrome/browser/android/ntp/most_visited_sites_bridge.h

index e9f9bcdd3ae366039f9c0c32d77e05113f862b7a..18020c9ba8bf462fbc3ebfb7c5ea4105660ab87e 100644

--- a/chrome/browser/android/ntp/most_visited_sites_bridge.h

+++ b/chrome/browser/android/ntp/most_visited_sites_bridge.h

@@ -44,7 +44,8 @@ class MostVisitedSitesBridge {

JNIEnv* env,

const base::android::JavaParamRef<jobject>& obj,

const base::android::JavaParamRef<jintArray>& jtile_types,

- const base::android::JavaParamRef<jintArray>& jsources);

+ const base::android::JavaParamRef<jintArray>& jsources,

+ const base::android::JavaParamRef<jobjectArray>& jtile_urls);

void RecordOpenedMostVisitedItem(

JNIEnv* env,

const base::android::JavaParamRef<jobject>& obj,