chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java - Issue 2557513007: ntp_tiles::metrics: Add rappor metrics for impression URLs per icon type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java

Issue 2557513007: ntp_tiles::metrics: Add rappor metrics for impression URLs per icon type. (Closed)

Patch Set: Addressed comments. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java ('k') | chrome/browser/android/ntp/most_visited_sites_bridge.h » ('j') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java

index 2e19967f6cef79ea565b0bc7a1c381fd3b1e3070..fcf708569d65066b22f359b4c94927fa2debed1c 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java

@@ -68,7 +68,7 @@ public class FakeMostVisitedSites extends MostVisitedSites {

}

@Override

- public void recordPageImpression(int[] sources, int[] tileTypes) {

+ public void recordPageImpression(int[] sources, int[] tileTypes, String[] tileUrls) {

// Metrics are stubbed out.

}