Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2557513004: Remove explicit singletonness of ArcBridgeService part 3. (Closed)

Created:
4 years ago by hidehiko
Modified:
4 years ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, Matt Giuca, khmel
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove explicit singletonness of ArcBridgeService part 3. This CL replaces ArcBridgeService::Get() by ArcServiceManager::Get()->arc_bridge_service() conceptually. For error handling, now ArcServiceManager::Get() can return nullptr, if not available. BUG=657687 BUG=b/31079732 TEST=Ran bots. Committed: https://crrev.com/4573cdea03df32f06dbf9d0357a17ea3327cde24 Cr-Commit-Position: refs/heads/master@{#437219}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Total comments: 2

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -74 lines) Patch
M chrome/browser/chromeos/arc/arc_session_manager_unittest.cc View 1 2 6 chunks +15 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/arc/intent_helper/arc_settings_service_browsertest.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/tts_chromeos.cc View 3 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/task_manager/providers/arc/arc_process_task.cc View 3 chunks +16 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 1 2 2 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.h View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.cc View 6 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/arc_app_dialog_view_browsertest.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M components/arc/arc_service_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge.cc View 1 2 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
hidehiko
PTAL. lhchavez@: c/b/c/arc, components/arc bartfab@: c/b/policy, c/b/c/policy georgesak@: c/b/memory dmazzoni@: c/b/speech afakhry@: c/b/task_manager xiyuan@: c/b/ui/app_list ...
4 years ago (2016-12-06 14:43:11 UTC) #6
xiyuan
+khmel fyi c/b/ui/app_list lgtm
4 years ago (2016-12-06 17:36:08 UTC) #7
msw
c/b/ui/views lgtm with nits https://codereview.chromium.org/2557513004/diff/1/chrome/browser/ui/views/arc_app_dialog_view_browsertest.cc File chrome/browser/ui/views/arc_app_dialog_view_browsertest.cc (right): https://codereview.chromium.org/2557513004/diff/1/chrome/browser/ui/views/arc_app_dialog_view_browsertest.cc#newcode20 chrome/browser/ui/views/arc_app_dialog_view_browsertest.cc:20: #include "components/arc/arc_bridge_service.h" nit: remove if ...
4 years ago (2016-12-06 17:49:32 UTC) #8
afakhry
c/b/task_manager lgtm
4 years ago (2016-12-06 18:31:37 UTC) #9
Luis Héctor Chávez
https://codereview.chromium.org/2557513004/diff/1/components/arc/intent_helper/arc_intent_helper_bridge.cc File components/arc/intent_helper/arc_intent_helper_bridge.cc (right): https://codereview.chromium.org/2557513004/diff/1/components/arc/intent_helper/arc_intent_helper_bridge.cc#newcode148 components/arc/intent_helper/arc_intent_helper_bridge.cc:148: auto* intent_helper = nit: maybe intent_helper_holder? instance_holder?
4 years ago (2016-12-06 18:55:00 UTC) #10
hidehiko
Thank you for review. PTAL. https://codereview.chromium.org/2557513004/diff/1/chrome/browser/ui/views/arc_app_dialog_view_browsertest.cc File chrome/browser/ui/views/arc_app_dialog_view_browsertest.cc (right): https://codereview.chromium.org/2557513004/diff/1/chrome/browser/ui/views/arc_app_dialog_view_browsertest.cc#newcode20 chrome/browser/ui/views/arc_app_dialog_view_browsertest.cc:20: #include "components/arc/arc_bridge_service.h" On 2016/12/06 ...
4 years ago (2016-12-06 19:11:29 UTC) #11
Luis Héctor Chávez
lgtm with a minor comment I'm unsure how to resolve. https://codereview.chromium.org/2557513004/diff/20001/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc File chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc (right): https://codereview.chromium.org/2557513004/diff/20001/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc#newcode258 ...
4 years ago (2016-12-06 19:29:32 UTC) #12
Georges Khalil
chrome/browser/memory/ LGTM
4 years ago (2016-12-06 20:56:46 UTC) #13
bartfab (slow)
policy lgtm
4 years ago (2016-12-06 21:15:39 UTC) #14
dmazzoni
lgtm for chrome/browser/speech/tts_chromeos.cc
4 years ago (2016-12-07 06:34:10 UTC) #15
hidehiko
Thank you for review. I mis-operated to upload PS3 mixing rebase and change to address ...
4 years ago (2016-12-08 08:35:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557513004/40001
4 years ago (2016-12-08 08:35:36 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-08 09:16:29 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-08 09:18:19 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4573cdea03df32f06dbf9d0357a17ea3327cde24
Cr-Commit-Position: refs/heads/master@{#437219}

Powered by Google App Engine
This is Rietveld 408576698