Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4224)

Unified Diff: chrome/browser/chromeos/arc/arc_session_manager_unittest.cc

Issue 2557513004: Remove explicit singletonness of ArcBridgeService part 3. (Closed)
Patch Set: Address comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/arc/intent_helper/arc_settings_service_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
diff --git a/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc b/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
index 98b7e135f7c278cf2b97582f2ad00a88ae360e3f..10b1c54e719d68e3cb2941e0e84e8feffbc40e5f 100644
--- a/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
+++ b/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
@@ -12,6 +12,7 @@
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
#include "chrome/browser/chromeos/arc/arc_optin_uma.h"
#include "chrome/browser/chromeos/arc/arc_session_manager.h"
@@ -29,6 +30,7 @@
#include "chromeos/dbus/dbus_thread_manager.h"
#include "chromeos/dbus/fake_session_manager_client.h"
#include "components/arc/arc_bridge_service.h"
+#include "components/arc/arc_service_manager.h"
#include "components/arc/test/fake_arc_bridge_service.h"
#include "components/prefs/pref_service.h"
#include "components/signin/core/account_id/account_id.h"
@@ -70,12 +72,14 @@ class ArcSessionManagerTest : public testing::Test {
profile_ = profile_builder.Build();
StartPreferenceSyncing();
- bridge_service_.reset(new FakeArcBridgeService());
- arc_session_manager_.reset(new ArcSessionManager(bridge_service_.get()));
+ ArcServiceManager::SetArcBridgeServiceForTesting(
+ base::MakeUnique<FakeArcBridgeService>());
+ arc_service_manager_ = base::MakeUnique<ArcServiceManager>(nullptr);
+ arc_session_manager_ = base::MakeUnique<ArcSessionManager>(
+ arc_service_manager_->arc_bridge_service());
// Check initial conditions.
- EXPECT_EQ(bridge_service_.get(), ArcBridgeService::Get());
- EXPECT_TRUE(ArcBridgeService::Get()->stopped());
+ EXPECT_TRUE(bridge_service()->stopped());
const AccountId account_id(
AccountId::FromUserEmailGaiaId("user@gmail.com", "1234567890"));
@@ -87,6 +91,8 @@ class ArcSessionManagerTest : public testing::Test {
void TearDown() override {
chromeos::WallpaperManager::Shutdown();
+ arc_session_manager_.reset();
+ arc_service_manager_.reset();
chromeos::DBusThreadManager::Shutdown();
}
@@ -97,7 +103,10 @@ class ArcSessionManagerTest : public testing::Test {
protected:
Profile* profile() { return profile_.get(); }
- FakeArcBridgeService* bridge_service() { return bridge_service_.get(); }
+ FakeArcBridgeService* bridge_service() {
+ return static_cast<FakeArcBridgeService*>(
+ arc_service_manager_->arc_bridge_service());
+ }
ArcSessionManager* arc_session_manager() {
return arc_session_manager_.get();
}
@@ -126,8 +135,8 @@ class ArcSessionManagerTest : public testing::Test {
}
content::TestBrowserThreadBundle thread_bundle_;
- std::unique_ptr<FakeArcBridgeService> bridge_service_;
std::unique_ptr<TestingProfile> profile_;
+ std::unique_ptr<ArcServiceManager> arc_service_manager_;
std::unique_ptr<ArcSessionManager> arc_session_manager_;
chromeos::ScopedUserManagerEnabler user_manager_enabler_;
base::ScopedTempDir temp_dir_;
« no previous file with comments | « no previous file | chrome/browser/chromeos/arc/intent_helper/arc_settings_service_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698