Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2557473003: PaymentApp: Factor out functions to serialize/deserialize manifest data. (Closed)

Created:
4 years ago by zino
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentApp: Factor out functions to serialize/deserialize manifest data. The functions will be used by other classes as well. For example, when we query all manifest data, it can be used. This CL doesn't change existing behavior. BUG=661608 TEST=existing unittests

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -161 lines) Patch
M content/browser/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
D content/browser/payments/payment_app_context.h View 1 1 chunk +0 lines, -64 lines 0 comments Download
D content/browser/payments/payment_app_context.cc View 1 1 chunk +0 lines, -69 lines 0 comments Download
A + content/browser/payments/payment_app_context_impl.h View 1 4 chunks +22 lines, -9 lines 0 comments Download
A content/browser/payments/payment_app_context_impl.cc View 1 1 chunk +113 lines, -0 lines 0 comments Download
M content/browser/payments/payment_app_manager.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/payments/payment_app_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/payments/payment_app_manager_unittest.cc View 1 3 chunks +34 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/storage_partition_impl.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
A content/public/browser/payment_app_context.h View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
zino
PTAL
4 years ago (2016-12-05 18:28:42 UTC) #3
please use gerrit instead
4 years ago (2016-12-05 20:33:31 UTC) #6
I'm not a big fan of refactoring for something that may or may not happen in the
future. The rule of thumb is to submit only CLs that fix bugs or add features.
Factoring out function X() should happen only when X() is called from multiple
places.

If this is a small part of a larger patch that you're submitting separately to
make reviewers' lives easier, then please make it clear. One way to do that
would be to upload all patches with links to each other in the description.
Another way is to write up a design doc with all steps described in there.

Powered by Google App Engine
This is Rietveld 408576698