Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2557403004: Check fullscreen manager before setting control state (Closed)

Created:
4 years ago by mdjones
Modified:
4 years ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check fullscreen manager before setting control state The fullscreen manager can be null in cases where a different activity is showing. This CL adds a check to make sure it is there before using it. BUG=672730, 670459 Committed: https://crrev.com/172d35b3cdc223d953ba341068b998ea88bfe705 Cr-Commit-Position: refs/heads/master@{#437578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mdjones
ptal
4 years ago (2016-12-09 16:55:53 UTC) #2
David Trainor- moved to gerrit
lgtm
4 years ago (2016-12-09 16:57:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557403004/1
4 years ago (2016-12-09 17:02:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 17:36:48 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-12 14:35:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/172d35b3cdc223d953ba341068b998ea88bfe705
Cr-Commit-Position: refs/heads/master@{#437578}

Powered by Google App Engine
This is Rietveld 408576698