Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2557403003: Temporarily remove unit testing from run-bindings-tests. (Closed)

Created:
4 years ago by dglazkov
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, Dirk Pranke, dglazkov
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily remove unit testing from run-bindings-tests. Turns out, typ treats the absence of the unit tests as failure, and we don't have any tests at the moment. R=peria,bashi,haraken BUG=672738 Committed: https://crrev.com/e41b9ae700214d41cf25c3bd9606aacf13209727 Cr-Commit-Position: refs/heads/master@{#437599}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M third_party/WebKit/Tools/Scripts/run-bindings-tests View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Yuki
lgtm
4 years ago (2016-12-09 15:40:24 UTC) #4
haraken
LGTM
4 years ago (2016-12-09 15:43:29 UTC) #5
Dirk Pranke
Heh, yes ... typ assumes that you wouldn't be calling it if you didn't have ...
4 years ago (2016-12-09 15:51:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557403003/1
4 years ago (2016-12-09 18:33:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 18:50:37 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-12 14:36:38 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e41b9ae700214d41cf25c3bd9606aacf13209727
Cr-Commit-Position: refs/heads/master@{#437599}

Powered by Google App Engine
This is Rietveld 408576698