Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2557353003: Changes OnWindowHierarchyChanged() to include transient parent (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes OnWindowHierarchyChanged() to include transient parent This is necessary for the case where a client creates a window, sets the transient parent and then adds it. Without this change the wm wouldn't know about the transient parent and would be in a weird state. BUG=663903 TEST=covered by tests R=ben@chromium.org, tsepez@chromium.org Committed: https://crrev.com/ae9171adecb864c873bbd1c475144a7d86385174 Cr-Commit-Position: refs/heads/master@{#437450}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : merge #

Patch Set 4 : merge again #

Patch Set 5 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -50 lines) Patch
M services/ui/public/interfaces/window_tree.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/public/interfaces/window_tree_constants.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M services/ui/ws/window_manager_client_unittest.cc View 1 3 5 chunks +41 lines, -3 lines 0 comments Download
M services/ui/ws/window_tree.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 2 chunks +12 lines, -6 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 2 3 4 9 chunks +76 lines, -29 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 32 (18 generated)
sky
tsepez: mojom ben: the rest
4 years ago (2016-12-08 19:26:48 UTC) #1
Ben Goodger (Google)
lgtm
4 years ago (2016-12-08 20:11:23 UTC) #6
Tom Sepez
mojom LGTM
4 years ago (2016-12-08 20:15:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557353003/40001
4 years ago (2016-12-08 20:29:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/135498)
4 years ago (2016-12-08 21:14:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557353003/40001
4 years ago (2016-12-08 23:07:44 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/135604)
4 years ago (2016-12-08 23:14:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557353003/60001
4 years ago (2016-12-08 23:33:12 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/177524)
4 years ago (2016-12-08 23:42:33 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557353003/60001
4 years ago (2016-12-09 00:23:16 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/331533)
4 years ago (2016-12-09 01:19:26 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557353003/80001
4 years ago (2016-12-09 01:33:33 UTC) #28
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-09 03:30:50 UTC) #30
commit-bot: I haz the power
4 years ago (2016-12-09 03:35:03 UTC) #32
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ae9171adecb864c873bbd1c475144a7d86385174
Cr-Commit-Position: refs/heads/master@{#437450}

Powered by Google App Engine
This is Rietveld 408576698