Revert of Set user_gesture bit at NavigationHandle creation time.

Revert of Set user_gesture bit at NavigationHandle creation time. (patchset #19 id:350001 of https://codereview.chromium.org/2499313003/ )

Reason for revert:
This patch broke UrlOverridingTest#testOpenWindowFromUserGesture. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.externalnav.UrlOverridingTest%23testOpenWindowFromUserGesture

Original issue's description:
> Set user_gesture bit at NavigationHandle creation time.
>
> Previously, the user_gesture bit was set at different places and could be
> updated during the lifetime of a navigation, such as in WillStartNavigation
> and at commit time. In practice, whether a navigation was initiated by
> user gesture is known at the time a NavigationHandle is created.
> This change makes has_user_gesture_ a const member of NavigationHandleImpl,
> and sets it once at construction time.
>
> clamy suggested that we could set the user gesture bit at NavHandle
> construction time in the following places:
> - PlzNavigate: we have it when we create the handle.
> - Regular navs: we add the parameter to DidStartProvisionalLoad.
> - same-page navs: we create the NavigationHandle in DidCommitProvisionalLoad,
>   where we have the information.
>
> This patch makes the following changes:
> - adds a gesture param to NavigationHandleImpl::Create
> - adds a gesture boolean param to FrameHostMsg_DidStartProvisionalLoad,
>   which is passed to RenderFrameHostImpl::OnDidStartProvisionalLoad
> - removes the has_user_gesture boolean param from
>   NavigationHandleImpl::WillStartRequest
>
> For the time being, we continue to update the gesture_ value at commit time.
> Once crbug.com/667572 is addressed, gesture_ can be made a const member and
> we can stop updating it at commit time.
>
> BUG=665952
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/318ecffe833701cfd6db2ac43491ace0a68e18af
> Cr-Commit-Position: refs/heads/master@{#435354}

TBR=bauerb@chromium.org,clamy@chromium.org,michaelbai@chromium.org,rdevlin.cronin@chromium.org,tsepez@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=665952
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/bb887bb505f695aba03436ed8e5fd4b772265921
Cr-Commit-Position: refs/heads/master@{#438147}

[Bryan McQuade, 2016-12-08 01:27:03]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2016-12-08 01:27:04]

Created Revert of Set user_gesture bit at NavigationHandle creation time.

[Bryan McQuade, 2016-12-08 01:27:22]

The CQ bit was unchecked by bmcquade@chromium.org

[Bryan McQuade, 2016-12-08 01:27:36]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 01:28:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 01:33:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:33:32]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Bryan McQuade, 2016-12-08 01:39:03]

Description was changed from

==========
Revert of Set user_gesture bit at NavigationHandle creation time. (patchset #19
id:350001 of https://codereview.chromium.org/2499313003/ )

Reason for revert:
This patch broke UrlOverridingTest#testOpenWindowFromUserGesture. See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

Original issue's description:
> Set user_gesture bit at NavigationHandle creation time.
> 
> Previously, the user_gesture bit was set at different places and could be
> updated during the lifetime of a navigation, such as in WillStartNavigation
> and at commit time. In practice, whether a navigation was initiated by
> user gesture is known at the time a NavigationHandle is created.
> This change makes has_user_gesture_ a const member of NavigationHandleImpl,
> and sets it once at construction time.
> 
> clamy suggested that we could set the user gesture bit at NavHandle
> construction time in the following places:
> - PlzNavigate: we have it when we create the handle.
> - Regular navs: we add the parameter to DidStartProvisionalLoad.
> - same-page navs: we create the NavigationHandle in DidCommitProvisionalLoad,
>   where we have the information.
> 
> This patch makes the following changes:
> - adds a gesture param to NavigationHandleImpl::Create
> - adds a gesture boolean param to FrameHostMsg_DidStartProvisionalLoad,
>   which is passed to RenderFrameHostImpl::OnDidStartProvisionalLoad
> - removes the has_user_gesture boolean param from
>   NavigationHandleImpl::WillStartRequest
> 
> For the time being, we continue to update the gesture_ value at commit time.
> Once crbug.com/667572 is addressed, gesture_ can be made a const member and
> we can stop updating it at commit time.
> 
> BUG=665952
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/318ecffe833701cfd6db2ac43491ace0a68e18af
> Cr-Commit-Position: refs/heads/master@{#435354}

TBR=bauerb@chromium.org,clamy@chromium.org,michaelbai@chromium.org,rdevlin.cr...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=665952
==========

to

==========
Revert of Set user_gesture bit at NavigationHandle creation time. (patchset #19
id:350001 of https://codereview.chromium.org/2499313003/ )

Reason for revert:
This patch broke UrlOverridingTest#testOpenWindowFromUserGesture. See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

Original issue's description:
> Set user_gesture bit at NavigationHandle creation time.
> 
> Previously, the user_gesture bit was set at different places and could be
> updated during the lifetime of a navigation, such as in WillStartNavigation
> and at commit time. In practice, whether a navigation was initiated by
> user gesture is known at the time a NavigationHandle is created.
> This change makes has_user_gesture_ a const member of NavigationHandleImpl,
> and sets it once at construction time.
> 
> clamy suggested that we could set the user gesture bit at NavHandle
> construction time in the following places:
> - PlzNavigate: we have it when we create the handle.
> - Regular navs: we add the parameter to DidStartProvisionalLoad.
> - same-page navs: we create the NavigationHandle in DidCommitProvisionalLoad,
>   where we have the information.
> 
> This patch makes the following changes:
> - adds a gesture param to NavigationHandleImpl::Create
> - adds a gesture boolean param to FrameHostMsg_DidStartProvisionalLoad,
>   which is passed to RenderFrameHostImpl::OnDidStartProvisionalLoad
> - removes the has_user_gesture boolean param from
>   NavigationHandleImpl::WillStartRequest
> 
> For the time being, we continue to update the gesture_ value at commit time.
> Once crbug.com/667572 is addressed, gesture_ can be made a const member and
> we can stop updating it at commit time.
> 
> BUG=665952
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/318ecffe833701cfd6db2ac43491ace0a68e18af
> Cr-Commit-Position: refs/heads/master@{#435354}

TBR=bauerb@chromium.org,clamy@chromium.org,michaelbai@chromium.org,rdevlin.cr...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=665952
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Bryan McQuade, 2016-12-08 01:39:06]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 01:39:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 03:18:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 03:18:42]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Bryan McQuade, 2016-12-08 12:07:15]

PTAL, this broke a test, so I need to revert. The patch changed slightly, so
Camille, I'd like to get your re-review before I commit, thanks!

[Bernhard Bauer, 2016-12-08 12:12:35]

LGTM for where I'm an OWNER.

For ease of (mostly Camille's I guess) reviewing, what are the changes you had
to make?

[Bryan McQuade, 2016-12-08 13:50:57]

On 2016/12/08 at 12:12:35, bauerb wrote:
> LGTM for where I'm an OWNER.
> 
> For ease of (mostly Camille's I guess) reviewing, what are the changes you had
to make?

Ah, sure, good question, thanks!

It appears that the NavigationHandleImpl constructor changed after I landed this
patch, which meant calls to it did not apply cleanly. The specific pieces of
code where patches didn't apply cleanly are:

--- content/browser/frame_host/navigation_handle_impl.cc
+++ content/browser/frame_host/navigation_handle_impl.cc
@@ -56,12 +56,10 @@
     bool is_srcdoc,
     const base::TimeTicks& navigation_start,
     int pending_nav_entry_id,
-    NavigationGesture gesture,
     bool started_from_context_menu) {
   return std::unique_ptr<NavigationHandleImpl>(new NavigationHandleImpl(
       url, frame_tree_node, is_renderer_initiated, is_same_page, is_srcdoc,
-      navigation_start, pending_nav_entry_id, gesture,
-      started_from_context_menu));
+      navigation_start, pending_nav_entry_id, started_from_context_menu));
 }
 
 NavigationHandleImpl::NavigationHandleImpl(
--- content/browser/frame_host/navigation_handle_impl_unittest.cc
+++ content/browser/frame_host/navigation_handle_impl_unittest.cc
@@ -68,12 +68,8 @@
   void SetUp() override {
     RenderViewHostImplTestHarness::SetUp();
     test_handle_ = NavigationHandleImpl::Create(
-        GURL(), main_test_rfh()->frame_tree_node(),
-        true,   // is_renderer_initiated
-        false,  // is_same_page
-        false,  // is_srcdoc
-        base::TimeTicks::Now(), 0, NavigationGestureAuto,
-        false);  // started_from_context_menu
+        GURL(), main_test_rfh()->frame_tree_node(), true, false, false,
+        base::TimeTicks::Now(), 0, false);
     EXPECT_EQ(REQUEST_CONTEXT_TYPE_UNSPECIFIED,
               test_handle_->request_context_type_);
     contents()->GetMainFrame()->InitializeRenderFrameIfNeeded();
--- content/browser/frame_host/navigator_impl.cc
+++ content/browser/frame_host/navigator_impl.cc
@@ -209,8 +208,7 @@
       is_renderer_initiated,
       false,             // is_same_page
       is_iframe_srcdoc,  // is_srcdoc
-      navigation_start, pending_nav_entry_id, gesture,
-      started_from_context_menu));
+      navigation_start, pending_nav_entry_id, started_from_context_menu));
 }
 
 void NavigatorImpl::DidFailProvisionalLoadWithError(
--- content/browser/frame_host/render_frame_host_impl.cc
+++ content/browser/frame_host/render_frame_host_impl.cc
@@ -3289,8 +3288,7 @@
     return NavigationHandleImpl::Create(
         params.url, frame_tree_node_, is_renderer_initiated,
         params.was_within_same_page, params.is_srcdoc, base::TimeTicks::Now(),
-        pending_nav_entry_id, params.gesture,
-        false);  // started_from_context_menu
+        pending_nav_entry_id, false);  // started_from_context_menu
   }
 
   // Determine if the current NavigationHandle can be used.
@@ -3342,8 +3340,7 @@
   return NavigationHandleImpl::Create(
       params.url, frame_tree_node_, is_renderer_initiated,
       params.was_within_same_page, params.is_srcdoc, base::TimeTicks::Now(),
-      entry_id_for_data_nav, params.gesture,
-      false);  // started_from_context_menu
+      entry_id_for_data_nav, false);  // started_from_context_menu
 }
 
 }  // namespace content
--- content/common/frame_messages.h
+++ content/common/frame_messages.h
@@ -393,6 +393,7 @@
   IPC_STRUCT_TRAITS_MEMBER(should_create_service_worker)
   IPC_STRUCT_TRAITS_MEMBER(navigation_timing)
   IPC_STRUCT_TRAITS_MEMBER(service_worker_provider_id)
+  IPC_STRUCT_TRAITS_MEMBER(has_user_gesture)
 #if defined(OS_ANDROID)
   IPC_STRUCT_TRAITS_MEMBER(data_url_as_string)
 #endif
--- content/common/navigation_params.cc
+++ content/common/navigation_params.cc
@@ -134,7 +134,8 @@
       is_view_source(false),
       should_clear_history_list(false),
       should_create_service_worker(false),
-      service_worker_provider_id(kInvalidServiceWorkerProviderId) {}
+      service_worker_provider_id(kInvalidServiceWorkerProviderId),
+      has_user_gesture(false) {}
 
 RequestNavigationParams::RequestNavigationParams(
     bool is_overriding_user_agent,
@@ -169,7 +171,8 @@
       is_view_source(is_view_source),
       should_clear_history_list(should_clear_history_list),
       should_create_service_worker(false),
-      service_worker_provider_id(kInvalidServiceWorkerProviderId) {}
+      service_worker_provider_id(kInvalidServiceWorkerProviderId),
+      has_user_gesture(has_user_gesture) {}
 
 RequestNavigationParams::RequestNavigationParams(
     const RequestNavigationParams& other) = default;

[Devlin, 2016-12-08 16:23:11]

extensions rs lgtm

[clamy, 2016-12-08 17:25:31]

Thanks for providing the diff, it was very helpful! The revert lgtm.

[clamy, 2016-12-08 18:09:43]

Also, as an fyi, I have https://codereview.chromium.org/2099243002/ in CQ. If it
lands it could conflict with your patch, since it modifies the constructor of
BeginNavigationParams. The rebase should be fairly straightforward though.

[dgn, 2016-12-09 10:53:56]

FYI: n5x_swarming_rel has just been dropped because of its flakiness
(https://bugs.chromium.org/p/chromium/issues/detail?id=672382)

[Bryan McQuade, 2016-12-12 14:44:36]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 14:44:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 16:45:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 16:45:13]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Bryan McQuade, 2016-12-13 12:56:22]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2016-12-13 12:56:23]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
clamy@chromium.org, rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2557233002/#ps320001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-13 12:56:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 13:01:24]

CQ is committing da patch.

Bot data: {"patchset_id": 320001, "attempt_start_ts": 1481633782643600,
"parent_rev": "b90d5cf015e336de520a025c95ec33e8a20b0211", "commit_rev":
"15bc37c6f8cac4d014d16b49b0fb5cd08694bf2b"}

[commit-bot: I haz the power, 2016-12-13 13:02:29]

Description was changed from

==========
Revert of Set user_gesture bit at NavigationHandle creation time. (patchset #19
id:350001 of https://codereview.chromium.org/2499313003/ )

Reason for revert:
This patch broke UrlOverridingTest#testOpenWindowFromUserGesture. See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

Original issue's description:
> Set user_gesture bit at NavigationHandle creation time.
> 
> Previously, the user_gesture bit was set at different places and could be
> updated during the lifetime of a navigation, such as in WillStartNavigation
> and at commit time. In practice, whether a navigation was initiated by
> user gesture is known at the time a NavigationHandle is created.
> This change makes has_user_gesture_ a const member of NavigationHandleImpl,
> and sets it once at construction time.
> 
> clamy suggested that we could set the user gesture bit at NavHandle
> construction time in the following places:
> - PlzNavigate: we have it when we create the handle.
> - Regular navs: we add the parameter to DidStartProvisionalLoad.
> - same-page navs: we create the NavigationHandle in DidCommitProvisionalLoad,
>   where we have the information.
> 
> This patch makes the following changes:
> - adds a gesture param to NavigationHandleImpl::Create
> - adds a gesture boolean param to FrameHostMsg_DidStartProvisionalLoad,
>   which is passed to RenderFrameHostImpl::OnDidStartProvisionalLoad
> - removes the has_user_gesture boolean param from
>   NavigationHandleImpl::WillStartRequest
> 
> For the time being, we continue to update the gesture_ value at commit time.
> Once crbug.com/667572 is addressed, gesture_ can be made a const member and
> we can stop updating it at commit time.
> 
> BUG=665952
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/318ecffe833701cfd6db2ac43491ace0a68e18af
> Cr-Commit-Position: refs/heads/master@{#435354}

TBR=bauerb@chromium.org,clamy@chromium.org,michaelbai@chromium.org,rdevlin.cr...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=665952
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert of Set user_gesture bit at NavigationHandle creation time. (patchset #19
id:350001 of https://codereview.chromium.org/2499313003/ )

Reason for revert:
This patch broke UrlOverridingTest#testOpenWindowFromUserGesture. See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

Original issue's description:
> Set user_gesture bit at NavigationHandle creation time.
>
> Previously, the user_gesture bit was set at different places and could be
> updated during the lifetime of a navigation, such as in WillStartNavigation
> and at commit time. In practice, whether a navigation was initiated by
> user gesture is known at the time a NavigationHandle is created.
> This change makes has_user_gesture_ a const member of NavigationHandleImpl,
> and sets it once at construction time.
>
> clamy suggested that we could set the user gesture bit at NavHandle
> construction time in the following places:
> - PlzNavigate: we have it when we create the handle.
> - Regular navs: we add the parameter to DidStartProvisionalLoad.
> - same-page navs: we create the NavigationHandle in DidCommitProvisionalLoad,
>   where we have the information.
>
> This patch makes the following changes:
> - adds a gesture param to NavigationHandleImpl::Create
> - adds a gesture boolean param to FrameHostMsg_DidStartProvisionalLoad,
>   which is passed to RenderFrameHostImpl::OnDidStartProvisionalLoad
> - removes the has_user_gesture boolean param from
>   NavigationHandleImpl::WillStartRequest
>
> For the time being, we continue to update the gesture_ value at commit time.
> Once crbug.com/667572 is addressed, gesture_ can be made a const member and
> we can stop updating it at commit time.
>
> BUG=665952
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/318ecffe833701cfd6db2ac43491ace0a68e18af
> Cr-Commit-Position: refs/heads/master@{#435354}

TBR=bauerb@chromium.org,clamy@chromium.org,michaelbai@chromium.org,rdevlin.cr...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=665952
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2557233002
==========

[commit-bot: I haz the power, 2016-12-13 13:02:30]

Committed patchset #3 (id:320001)

[commit-bot: I haz the power, 2016-12-13 13:05:37]

Description was changed from

==========
Revert of Set user_gesture bit at NavigationHandle creation time. (patchset #19
id:350001 of https://codereview.chromium.org/2499313003/ )

Reason for revert:
This patch broke UrlOverridingTest#testOpenWindowFromUserGesture. See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

Original issue's description:
> Set user_gesture bit at NavigationHandle creation time.
>
> Previously, the user_gesture bit was set at different places and could be
> updated during the lifetime of a navigation, such as in WillStartNavigation
> and at commit time. In practice, whether a navigation was initiated by
> user gesture is known at the time a NavigationHandle is created.
> This change makes has_user_gesture_ a const member of NavigationHandleImpl,
> and sets it once at construction time.
>
> clamy suggested that we could set the user gesture bit at NavHandle
> construction time in the following places:
> - PlzNavigate: we have it when we create the handle.
> - Regular navs: we add the parameter to DidStartProvisionalLoad.
> - same-page navs: we create the NavigationHandle in DidCommitProvisionalLoad,
>   where we have the information.
>
> This patch makes the following changes:
> - adds a gesture param to NavigationHandleImpl::Create
> - adds a gesture boolean param to FrameHostMsg_DidStartProvisionalLoad,
>   which is passed to RenderFrameHostImpl::OnDidStartProvisionalLoad
> - removes the has_user_gesture boolean param from
>   NavigationHandleImpl::WillStartRequest
>
> For the time being, we continue to update the gesture_ value at commit time.
> Once crbug.com/667572 is addressed, gesture_ can be made a const member and
> we can stop updating it at commit time.
>
> BUG=665952
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/318ecffe833701cfd6db2ac43491ace0a68e18af
> Cr-Commit-Position: refs/heads/master@{#435354}

TBR=bauerb@chromium.org,clamy@chromium.org,michaelbai@chromium.org,rdevlin.cr...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=665952
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2557233002
==========

to

==========
Revert of Set user_gesture bit at NavigationHandle creation time. (patchset #19
id:350001 of https://codereview.chromium.org/2499313003/ )

Reason for revert:
This patch broke UrlOverridingTest#testOpenWindowFromUserGesture. See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

Original issue's description:
> Set user_gesture bit at NavigationHandle creation time.
>
> Previously, the user_gesture bit was set at different places and could be
> updated during the lifetime of a navigation, such as in WillStartNavigation
> and at commit time. In practice, whether a navigation was initiated by
> user gesture is known at the time a NavigationHandle is created.
> This change makes has_user_gesture_ a const member of NavigationHandleImpl,
> and sets it once at construction time.
>
> clamy suggested that we could set the user gesture bit at NavHandle
> construction time in the following places:
> - PlzNavigate: we have it when we create the handle.
> - Regular navs: we add the parameter to DidStartProvisionalLoad.
> - same-page navs: we create the NavigationHandle in DidCommitProvisionalLoad,
>   where we have the information.
>
> This patch makes the following changes:
> - adds a gesture param to NavigationHandleImpl::Create
> - adds a gesture boolean param to FrameHostMsg_DidStartProvisionalLoad,
>   which is passed to RenderFrameHostImpl::OnDidStartProvisionalLoad
> - removes the has_user_gesture boolean param from
>   NavigationHandleImpl::WillStartRequest
>
> For the time being, we continue to update the gesture_ value at commit time.
> Once crbug.com/667572 is addressed, gesture_ can be made a const member and
> we can stop updating it at commit time.
>
> BUG=665952
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/318ecffe833701cfd6db2ac43491ace0a68e18af
> Cr-Commit-Position: refs/heads/master@{#435354}

TBR=bauerb@chromium.org,clamy@chromium.org,michaelbai@chromium.org,rdevlin.cr...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=665952
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/bb887bb505f695aba03436ed8e5fd4b772265921
Cr-Commit-Position: refs/heads/master@{#438147}
==========

[commit-bot: I haz the power, 2016-12-13 13:05:39]

Patchset 3 (id:??) landed as
https://crrev.com/bb887bb505f695aba03436ed8e5fd4b772265921
Cr-Commit-Position: refs/heads/master@{#438147}