Fix subframe loads with RenderViewTest when PlzNavigate is enabled.

Fix subframe loads with RenderViewTest when PlzNavigate is enabled.

While main frame loads already disabled the load being handled by the browser (in RenderViewTest::LoadHTML), requests from subframes are created inside Blink and so were missing that flag. Fix this by adding it in TestRenderFrame. Note this only modifies WebURLRequest::setCheckForBrowserSideNavigation, so that the other codepaths that check IsBrowserSideNavigationEnabled don't see any behavior change.

This fixes
ThreatDOMDetailsTest.Everything
with PlzNavigate.

BUG=504347
Committed: https://crrev.com/4a5ed276b2e0cfa9a1d76fa1ca2ea296601837ef
Cr-Commit-Position: refs/heads/master@{#437654}

[jam, 2016-12-08 01:22:44]

Patchset #1 (id:1) has been deleted

[jam, 2016-12-08 01:22:54]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 01:23:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-12-08 01:24:19]

Description was changed from

==========
Fix subframe loads with RenderViewTest when PlzNavigate is enabled.

While main frame loads already disabled the load being handled by the browser
(in RenderViewTest::LoadHTML), requests from subframes were being created inside
Blink and so were missing that flag. Add it in TestRenderFrame.

This fixes
ThreatDOMDetailsTest.Everything
with PlzNavigate.

BUG=504347
==========

to

==========
Fix subframe loads with RenderViewTest when PlzNavigate is enabled.

While main frame loads already disabled the load being handled by the browser
(in RenderViewTest::LoadHTML), requests from subframes were being created inside
Blink and so were missing that flag. Add it in TestRenderFrame.

This fixes
ThreatDOMDetailsTest.Everything
with PlzNavigate.

BUG=504347
==========

[jam, 2016-12-08 01:24:19]

jam@chromium.org changed reviewers:
+ ananta@chromium.org

[jam, 2016-12-08 01:29:33]

Description was changed from

==========
Fix subframe loads with RenderViewTest when PlzNavigate is enabled.

While main frame loads already disabled the load being handled by the browser
(in RenderViewTest::LoadHTML), requests from subframes were being created inside
Blink and so were missing that flag. Add it in TestRenderFrame.

This fixes
ThreatDOMDetailsTest.Everything
with PlzNavigate.

BUG=504347
==========

to

==========
Fix subframe loads with RenderViewTest when PlzNavigate is enabled.

While main frame loads already disabled the load being handled by the browser
(in RenderViewTest::LoadHTML), requests from subframes were being created inside
Blink and so were missing that flag. Add it in TestRenderFrame. Note this only
modifies WebURLRequest::setCheckForBrowserSideNavigation, so that the other
codepaths that check IsBrowserSideNavigationEnabled don't see any behavior
change.

This fixes
ThreatDOMDetailsTest.Everything
with PlzNavigate.

BUG=504347
==========

[commit-bot: I haz the power, 2016-12-08 01:37:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:37:02]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2016-12-08 01:39:36]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 01:40:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 01:51:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:52:00]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2016-12-08 01:55:00]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 01:55:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 03:06:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 03:06:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2016-12-08 04:12:10]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 04:12:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-12-08 04:55:22]

Description was changed from

==========
Fix subframe loads with RenderViewTest when PlzNavigate is enabled.

While main frame loads already disabled the load being handled by the browser
(in RenderViewTest::LoadHTML), requests from subframes were being created inside
Blink and so were missing that flag. Add it in TestRenderFrame. Note this only
modifies WebURLRequest::setCheckForBrowserSideNavigation, so that the other
codepaths that check IsBrowserSideNavigationEnabled don't see any behavior
change.

This fixes
ThreatDOMDetailsTest.Everything
with PlzNavigate.

BUG=504347
==========

to

==========
Fix subframe loads with RenderViewTest when PlzNavigate is enabled.

While main frame loads already disabled the load being handled by the browser
(in RenderViewTest::LoadHTML), requests from subframes are created inside Blink
and so were missing that flag. Fix this by adding it in TestRenderFrame. Note
this only modifies WebURLRequest::setCheckForBrowserSideNavigation, so that the
other codepaths that check IsBrowserSideNavigationEnabled don't see any behavior
change.

This fixes
ThreatDOMDetailsTest.Everything
with PlzNavigate.

BUG=504347
==========

[commit-bot: I haz the power, 2016-12-08 05:01:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 05:01:16]

Dry run: This issue passed the CQ dry run.

[jam39, 2016-12-08 16:19:01]

jem456.vasishta@gmail.com changed reviewers:
+ jem456.vasishta@gmail.com

[jam39, 2016-12-08 16:19:01]

https://codereview.chromium.org/2557223002/diff/80001/content/test/test_rende...
File content/test/test_render_frame.cc (right):

https://codereview.chromium.org/2557223002/diff/80001/content/test/test_rende...
content/test/test_render_frame.cc:82: // will be created inside Blink and it
wono't have this flag set.
won't *

[jam, 2016-12-08 17:19:00]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 17:19:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 18:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 18:34:14]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[ananta, 2016-12-08 22:57:05]

https://codereview.chromium.org/2557223002/diff/100001/content/test/test_rend...
File content/test/test_render_frame.cc (right):

https://codereview.chromium.org/2557223002/diff/100001/content/test/test_rend...
content/test/test_render_frame.cc:77:
info.urlRequest.checkForBrowserSideNavigation() &&
is this check correct? Should it be !checkforBrowser?

[jam, 2016-12-08 23:01:28]

https://codereview.chromium.org/2557223002/diff/100001/content/test/test_rend...
File content/test/test_render_frame.cc (right):

https://codereview.chromium.org/2557223002/diff/100001/content/test/test_rend...
content/test/test_render_frame.cc:77:
info.urlRequest.checkForBrowserSideNavigation() &&
On 2016/12/08 22:57:05, ananta wrote:
> is this check correct? Should it be !checkforBrowser?

The purpose of this if statement is to disable plznavigate for subframe
requests, which is done by setting CheckForBrowserSideNavigation=false. If
"!checkforBrowser" is the check, then that's already the case.

[jam, 2016-12-09 15:45:25]

jam@chromium.org changed reviewers:
- jem456.vasishta@gmail.com

[jam, 2016-12-09 17:29:09]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 17:29:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ananta, 2016-12-09 19:47:17]

lgtm

[commit-bot: I haz the power, 2016-12-09 20:06:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 20:06:18]

Dry run: This issue passed the CQ dry run.

[jam, 2016-12-09 20:17:55]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-12-09 20:18:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 21:09:55]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481314675810460,
"parent_rev": "8ffedf76b8ce7678b0ba2d72fb29db8ad94e1a6f", "commit_rev":
"2cef54680b0033d4fcf357c3b1ccd6d669fcd0d3"}

[commit-bot: I haz the power, 2016-12-09 21:10:24]

Description was changed from

==========
Fix subframe loads with RenderViewTest when PlzNavigate is enabled.

While main frame loads already disabled the load being handled by the browser
(in RenderViewTest::LoadHTML), requests from subframes are created inside Blink
and so were missing that flag. Fix this by adding it in TestRenderFrame. Note
this only modifies WebURLRequest::setCheckForBrowserSideNavigation, so that the
other codepaths that check IsBrowserSideNavigationEnabled don't see any behavior
change.

This fixes
ThreatDOMDetailsTest.Everything
with PlzNavigate.

BUG=504347
==========

to

==========
Fix subframe loads with RenderViewTest when PlzNavigate is enabled.

While main frame loads already disabled the load being handled by the browser
(in RenderViewTest::LoadHTML), requests from subframes are created inside Blink
and so were missing that flag. Fix this by adding it in TestRenderFrame. Note
this only modifies WebURLRequest::setCheckForBrowserSideNavigation, so that the
other codepaths that check IsBrowserSideNavigationEnabled don't see any behavior
change.

This fixes
ThreatDOMDetailsTest.Everything
with PlzNavigate.

BUG=504347

Review-Url: https://codereview.chromium.org/2557223002
==========

[commit-bot: I haz the power, 2016-12-09 21:10:25]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-12-12 14:40:53]

Description was changed from

==========
Fix subframe loads with RenderViewTest when PlzNavigate is enabled.

While main frame loads already disabled the load being handled by the browser
(in RenderViewTest::LoadHTML), requests from subframes are created inside Blink
and so were missing that flag. Fix this by adding it in TestRenderFrame. Note
this only modifies WebURLRequest::setCheckForBrowserSideNavigation, so that the
other codepaths that check IsBrowserSideNavigationEnabled don't see any behavior
change.

This fixes
ThreatDOMDetailsTest.Everything
with PlzNavigate.

BUG=504347

Review-Url: https://codereview.chromium.org/2557223002
==========

to

==========
Fix subframe loads with RenderViewTest when PlzNavigate is enabled.

While main frame loads already disabled the load being handled by the browser
(in RenderViewTest::LoadHTML), requests from subframes are created inside Blink
and so were missing that flag. Fix this by adding it in TestRenderFrame. Note
this only modifies WebURLRequest::setCheckForBrowserSideNavigation, so that the
other codepaths that check IsBrowserSideNavigationEnabled don't see any behavior
change.

This fixes
ThreatDOMDetailsTest.Everything
with PlzNavigate.

BUG=504347

Committed: https://crrev.com/4a5ed276b2e0cfa9a1d76fa1ca2ea296601837ef
Cr-Commit-Position: refs/heads/master@{#437654}
==========

[commit-bot: I haz the power, 2016-12-12 14:40:54]

Patchset 5 (id:??) landed as
https://crrev.com/4a5ed276b2e0cfa9a1d76fa1ca2ea296601837ef
Cr-Commit-Position: refs/heads/master@{#437654}