Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: base/debug/crash_logging.cc

Issue 25572002: Enforce crash key registration in SetCrashKeyValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/crash_logging.cc
diff --git a/base/debug/crash_logging.cc b/base/debug/crash_logging.cc
index 6a36a916c62dcd2e102eafbcea28b1c2206670b6..acbc16d3b0cb79da215980ff1ba33595708797d9 100644
--- a/base/debug/crash_logging.cc
+++ b/base/debug/crash_logging.cc
@@ -51,9 +51,8 @@ void SetCrashKeyValue(const base::StringPiece& key,
const CrashKey* crash_key = LookupCrashKey(key);
- // TODO(rsesek): Do this:
- //DCHECK(crash_key) << "All crash keys must be registered before use "
- // << "(key = " << key << ")";
+ DCHECK(crash_key) << "All crash keys must be registered before use "
+ << "(key = " << key << ")";
// Handle the un-chunked case.
if (!crash_key || crash_key->max_length <= g_chunk_max_length_) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698