Enforce crash key registration in SetCrashKeyValue.

base/debug/crash_logging.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/debug/crash_logging.h"
 
 #include <cmath>
 #include <map>
 
 #include "base/debug/stack_trace.h"
@@ skipping 33 matching lines @@
 
 }  // namespace
 
 void SetCrashKeyValue(const base::StringPiece& key,
                       const base::StringPiece& value) {
   if (!g_set_key_func_)
     return;
 
   const CrashKey* crash_key = LookupCrashKey(key);
 
-  // TODO(rsesek): Do this:
-  //DCHECK(crash_key) << "All crash keys must be registered before use "
-  //                  << "(key = " << key << ")";
+  DCHECK(crash_key) << "All crash keys must be registered before use "
+                    << "(key = " << key << ")";
 
   // Handle the un-chunked case.
   if (!crash_key || crash_key->max_length <= g_chunk_max_length_) {
     g_set_key_func_(key, value);
     return;
   }
 
   // Unset the unused chunks.
   std::vector<std::string> chunks =
       ChunkCrashKeyValue(*crash_key, value, g_chunk_max_length_);
@@ skipping 125 matching lines @@
 void ResetCrashLoggingForTesting() {
   delete g_crash_keys_;
   g_crash_keys_ = NULL;
   g_chunk_max_length_ = 0;
   g_set_key_func_ = NULL;
   g_clear_key_func_ = NULL;
 }
 
 }  // namespace debug
 }  // namespace base