[Interpreter] Allocate registers used as call arguments on-demand.

[Interpreter] Allocate registers used as call arguments on-demand.

Allocate the registers used as arguments to a call on-demand after visiting the
argument (or reciever). This means that the visited expression can use registers
that would otherwise have been allocated for arguments which haven't been
visited yet.

The reason for doing this is to avoid keeping things live in registers
unecessarily for chained function calls, which avoids a memory leak for
functions which chain a large number of calls with large temporary arguments /
recievers.

BUG=chromium:672027
Review-Url: https://codereview.chromium.org/2557173004
Cr-Commit-Position: refs/heads/master@{#41714}
Committed: https://chromium.googlesource.com/v8/v8/+/ae741d042c834d2296769e04c27d6b2d4f6e469b

[rmcilroy, 2016-12-08 16:12:46]

rmcilroy@chromium.org changed reviewers:
+ mythria@chromium.org, ulan@chromium.org

[rmcilroy, 2016-12-08 16:12:46]

Mythri PTAL, Ulan as FYI.

[rmcilroy, 2016-12-08 16:13:40]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 16:13:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 16:15:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 16:15:15]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/17521)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30289)
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/19129)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/19254)

[rmcilroy, 2016-12-12 10:20:03]

Ping.

[mythria, 2016-12-12 11:16:43]

Nice, lgtm.

https://codereview.chromium.org/2557173004/diff/1/src/interpreter/bytecode-ge...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2557173004/diff/1/src/interpreter/bytecode-ge...
src/interpreter/bytecode-generator.cc:3222: Register destination =
register_allocator()->GrowRegisterList(reg_list);
May be a comment here saying we have to GrowRegisterList after visiting the
destination to avoid dead registers that may contain references, to avoid
accidentally changing this with a call to VisitForRegisterValue after allocating
the destination.

[rmcilroy, 2016-12-14 22:55:14]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 22:55:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2016-12-14 22:59:40]

Patchset #4 (id:60001) has been deleted

[rmcilroy, 2016-12-14 23:00:04]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 23:00:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 23:06:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 23:06:06]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[rmcilroy, 2016-12-15 10:18:02]

https://codereview.chromium.org/2557173004/diff/1/src/interpreter/bytecode-ge...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2557173004/diff/1/src/interpreter/bytecode-ge...
src/interpreter/bytecode-generator.cc:3222: Register destination =
register_allocator()->GrowRegisterList(reg_list);
On 2016/12/12 11:16:43, mythria wrote:
> May be a comment here saying we have to GrowRegisterList after visiting the
> destination to avoid dead registers that may contain references, to avoid
> accidentally changing this with a call to VisitForRegisterValue after
allocating
> the destination.

Done.

[rmcilroy, 2016-12-15 10:33:29]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-12-15 10:33:29]

The patchset sent to the CQ was uploaded after l-g-t-m from mythria@chromium.org
Link to the patchset: https://codereview.chromium.org/2557173004/#ps100001
(title: "Fix release build unused variable")

[commit-bot: I haz the power, 2016-12-15 10:33:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 10:59:58]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481798009064500,
"parent_rev": "6c620e531268ca6dcdb858a75cc75c68e6b2a44b", "commit_rev":
"ae741d042c834d2296769e04c27d6b2d4f6e469b"}

[commit-bot: I haz the power, 2016-12-15 11:00:01]

Description was changed from

==========
[Interpreter] Allocate registers used as call arguments on-demand.

Allocate the registers used as arguments to a call on-demand after visiting the
argument (or reciever). This means that the visited expression can use registers
that would otherwise have been allocated for arguments which haven't been
visited yet.

The reason for doing this is to avoid keeping things live in registers
unecessarily for chained function calls, which avoids a memory leak for
functions which chain a large number of calls with large temporary arguments /
recievers.

BUG=chromium:672027
==========

to

==========
[Interpreter] Allocate registers used as call arguments on-demand.

Allocate the registers used as arguments to a call on-demand after visiting the
argument (or reciever). This means that the visited expression can use registers
that would otherwise have been allocated for arguments which haven't been
visited yet.

The reason for doing this is to avoid keeping things live in registers
unecessarily for chained function calls, which avoids a memory leak for
functions which chain a large number of calls with large temporary arguments /
recievers.

BUG=chromium:672027

Review-Url: https://codereview.chromium.org/2557173004
Cr-Commit-Position: refs/heads/master@{#41714}
Committed:
https://chromium.googlesource.com/v8/v8/+/ae741d042c834d2296769e04c27d6b2d4f6...
==========

[commit-bot: I haz the power, 2016-12-15 11:00:02]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/ae741d042c834d2296769e04c27d6b2d4f6...