Chromium Code Reviews
DescriptionRevert of Do not generate a microdump if there are no webview pointers on the stack. (patchset #5 id:80001 of https://codereview.chromium.org/2552753002/ )
Reason for revert:
Failed to compile on Android MIPS Builder
https://build.chromium.org/p/chromium.android/builders/Android%20MIPS%20Builder%20%28dbg%29/builds/7573
Original issue's description:
> Do not generate a microdump if there are no webview pointers on the stack.
>
> To determine the webview text section address range, we use the linker
> defines symbols __executable_start and __etext. These are passed to
> breakpad in the microdump extra info struct, causing it to not generate
> a microdump if the stack of the crashing thread does not contain a
> pointer into this region.
>
> BUG=664460
>
> Committed: https://crrev.com/19f0a50c6eab29917f459557b10cafc70428a4a2
> Cr-Commit-Position: refs/heads/master@{#437003}
TBR=primiano@chromium.org,torne@chromium.org,rsesek@chromium.org,tobiasjs@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664460
Committed: https://crrev.com/11d49438388ee3747531dde789ea365a85275b00
Cr-Commit-Position: refs/heads/master@{#437059}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||