Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2557143002: Revert of Do not generate a microdump if there are no webview pointers on the stack. (Closed)

Created:
4 years ago by the real yoland
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, sadrul, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Do not generate a microdump if there are no webview pointers on the stack. (patchset #5 id:80001 of https://codereview.chromium.org/2552753002/ ) Reason for revert: Failed to compile on Android MIPS Builder https://build.chromium.org/p/chromium.android/builders/Android%20MIPS%20Builder%20%28dbg%29/builds/7573 Original issue's description: > Do not generate a microdump if there are no webview pointers on the stack. > > To determine the webview text section address range, we use the linker > defines symbols __executable_start and __etext. These are passed to > breakpad in the microdump extra info struct, causing it to not generate > a microdump if the stack of the crashing thread does not contain a > pointer into this region. > > BUG=664460 > > Committed: https://crrev.com/19f0a50c6eab29917f459557b10cafc70428a4a2 > Cr-Commit-Position: refs/heads/master@{#437003} TBR=primiano@chromium.org,torne@chromium.org,rsesek@chromium.org,tobiasjs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664460 Committed: https://crrev.com/11d49438388ee3747531dde789ea365a85275b00 Cr-Commit-Position: refs/heads/master@{#437059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -65 lines) Patch
M android_webview/crash_reporter/aw_microdump_crash_reporter.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/crash_reporter/aw_microdump_crash_reporter.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 2 chunks +1 line, -14 lines 0 comments Download
M components/crash/content/app/breakpad_linux.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/crash/content/app/breakpad_linux.cc View 6 chunks +8 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
the real yoland
Created Revert of Do not generate a microdump if there are no webview pointers on ...
4 years ago (2016-12-07 21:11:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557143002/1
4 years ago (2016-12-07 21:11:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 21:16:02 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-07 21:17:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11d49438388ee3747531dde789ea365a85275b00
Cr-Commit-Position: refs/heads/master@{#437059}

Powered by Google App Engine
This is Rietveld 408576698