Revert of Do not generate a microdump if there are no webview pointers on the stack.

components/crash/content/app/breakpad_linux.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // For linux_syscall_support.h. This makes it safe to call embedded system
 // calls when in seccomp mode.
 
 #include "components/crash/content/app/breakpad_linux.h"
 
 #include <fcntl.h>
@@ skipping 92 matching lines @@
 #if defined(OS_ANDROID)
 char* g_process_type = nullptr;
 ExceptionHandler* g_microdump = nullptr;
 int g_signal_code_pipe_fd = -1;
 
 class MicrodumpInfo {
  public:
   MicrodumpInfo()
       : microdump_build_fingerprint_(nullptr),
         microdump_product_info_(nullptr),
-        microdump_gpu_fingerprint_(nullptr),
-        microdump_process_type_(nullptr),
-        interest_range_start_(0ul),
-        interest_range_end_(0ul),
-        suppress_microdump_based_on_interest_range_(false) {}
+        microdump_gpu_fingerprint_(nullptr) {}
 
   // The order in which SetGpuFingerprint and Initialize are called
   // may be dependent on the timing of the availability of GPU
   // information. For this reason, they can be called in either order,
   // resulting in the same effect.
   //
   // The following restrictions apply, however:
   // * Both methods must be called from the same thread.
   // * Both methods must be called at most once.
   //
   // Microdumps will only be generated if Initialize is called. If
   // SetGpuFingerprint has not been called called at the point at
   // which a microdump is generated, then the GPU fingerprint will be
   // UNKNOWN.
   void SetGpuFingerprint(const std::string& gpu_fingerprint);
-  void SetMicrodumpInterestRange(uintptr_t start, uintptr_t end);
   void Initialize(const std::string& process_type,
                   const char* product_name,
                   const char* product_version,
                   const char* android_build_fp);
 
  private:
   base::ThreadChecker thread_checker_;
   const char* microdump_build_fingerprint_;
   const char* microdump_product_info_;
   const char* microdump_gpu_fingerprint_;
   const char* microdump_process_type_;
-  uintptr_t interest_range_start_;
-  uintptr_t interest_range_end_;
-  bool suppress_microdump_based_on_interest_range_;
 };
 
 base::LazyInstance<MicrodumpInfo> g_microdump_info =
     LAZY_INSTANCE_INITIALIZER;
 
 #endif
 
 CrashKeyStorage* g_crash_keys = nullptr;
 
 // Writes the value |v| as 16 hex characters to the memory pointed at by
@@ skipping 715 matching lines @@
   ANNOTATE_LEAKING_OBJECT_PTR(microdump_gpu_fingerprint_);
 
   if (g_microdump) {
     MinidumpDescriptor minidump_descriptor(g_microdump->minidump_descriptor());
     minidump_descriptor.microdump_extra_info()->gpu_fingerprint =
         microdump_gpu_fingerprint_;
     g_microdump->set_minidump_descriptor(minidump_descriptor);
   }
 }
 
-void MicrodumpInfo::SetMicrodumpInterestRange(uintptr_t start, uintptr_t end) {
-  interest_range_start_ = start;
-  interest_range_end_ = end;
-  suppress_microdump_based_on_interest_range_ = true;
-
-  if (g_microdump) {
-    MinidumpDescriptor descriptor(g_microdump->minidump_descriptor());
-    google_breakpad::MicrodumpExtraInfo* microdump_extra_info =
-        descriptor.microdump_extra_info();
-    microdump_extra_info->interest_range_start = interest_range_start_;
-    microdump_extra_info->interest_range_end = interest_range_end_;
-    microdump_extra_info->suppress_microdump_based_on_interest_range = true;
-    g_microdump->set_minidump_descriptor(descriptor);
-  }
-}
-
 void MicrodumpInfo::Initialize(const std::string& process_type,
                                const char* product_name,
                                const char* product_version,
                                const char* android_build_fp) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(!g_microdump);
   // |process_type| for webview's browser process is kBrowserProcessType or
   // kWebViewSingleProcessType. |process_type| for chrome's browser process is
   // an empty string.
   bool is_browser_process = process_type.empty() ||
                             process_type == kWebViewSingleProcessType ||
                             process_type == kBrowserProcessType;
 
   MinidumpDescriptor descriptor(MinidumpDescriptor::kMicrodumpOnConsole);
-  google_breakpad::MicrodumpExtraInfo* microdump_extra_info =
-      descriptor.microdump_extra_info();
 
   if (product_name && product_version) {
     microdump_product_info_ =
         strdup((product_name + std::string(":") + product_version).c_str());
     ANNOTATE_LEAKING_OBJECT_PTR(microdump_product_info_);
-    microdump_extra_info->product_info = microdump_product_info_;
+    descriptor.microdump_extra_info()->product_info = microdump_product_info_;
   }
 
   microdump_process_type_ =
       strdup(process_type.empty() ? kBrowserProcessType : process_type.c_str());
   ANNOTATE_LEAKING_OBJECT_PTR(microdump_process_type_);
-  microdump_extra_info->process_type = microdump_process_type_;
+  descriptor.microdump_extra_info()->process_type = microdump_process_type_;
 
   if (android_build_fp) {
     microdump_build_fingerprint_ = strdup(android_build_fp);
     ANNOTATE_LEAKING_OBJECT_PTR(microdump_build_fingerprint_);
-    microdump_extra_info->build_fingerprint = microdump_build_fingerprint_;
+    descriptor.microdump_extra_info()->build_fingerprint =
+        microdump_build_fingerprint_;
   }
 
   if (microdump_gpu_fingerprint_) {
-    microdump_extra_info->gpu_fingerprint = microdump_gpu_fingerprint_;
+    descriptor.microdump_extra_info()->gpu_fingerprint =
+        microdump_gpu_fingerprint_;
   }
 
-  microdump_extra_info->interest_range_start = interest_range_start_;
-  microdump_extra_info->interest_range_end = interest_range_end_;
-  microdump_extra_info->suppress_microdump_based_on_interest_range =
-      suppress_microdump_based_on_interest_range_;
-
   g_microdump =
       new ExceptionHandler(descriptor, nullptr, MicrodumpCrashDone,
                            reinterpret_cast<void*>(is_browser_process),
                            true,  // Install handlers.
                            -1);   // Server file descriptor. -1 for in-process.
 
   if (process_type == kWebViewSingleProcessType ||
       process_type == kBrowserProcessType) {
     // TODO(tobiasjs): figure out what to do with on demand minidump on the
     // renderer process of webview.
@@ skipping 1003 matching lines @@
       base::android::BuildInfo::GetInstance()->android_build_fp();
 
   g_microdump_info.Get().Initialize(process_type, product_name, product_version,
                                     android_build_fp);
 }
 
 void AddGpuFingerprintToMicrodumpCrashHandler(
     const std::string& gpu_fingerprint) {
   g_microdump_info.Get().SetGpuFingerprint(gpu_fingerprint);
 }
-
-void SetNativeCodeTextAddrRange(uintptr_t start, uintptr_t end) {
-  g_microdump_info.Get().SetMicrodumpInterestRange(start, end);
-}
 #endif  // OS_ANDROID
 
 bool IsCrashReporterEnabled() {
   return g_is_crash_reporter_enabled;
 }
 
 }  // namespace breakpad