Change glimage to accept a type.

gpu/GLES2/extensions/CHROMIUM/CHROMIUM_map_image.txt

Index: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_map_image.txt
diff --git a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_map_image.txt b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_map_image.txt
index 6304fdace0feeb68efe850ed3187722a73ec4ead..d83b0fea36221c76a48a63a23f049a7c3637e901 100644
--- a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_map_image.txt
+++ b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_map_image.txt
@@ -17,7 +17,9 @@ Dependencies
 Overview
 
     This extension allows for more efficient uploading of texture data through
-    Chromium's OpenGL ES 2.0 implementation.
+    Chromium's OpenGL ES 2.0 implementation as well as enable hardware overlay
+    support by providing avility to create buffers capable of being scanned out

[reveman, 2014/04/30 11:31:28]

the ability

+    directly by the display controller.
 
     For security reasons Chromium accesses the GPU from a separate process. User
     processes are not allowed to access the GPU directly. This multi-process
@@ -39,7 +41,7 @@ New Tokens
 New Procedures and Functions
 
     GLuint CreateImageCHROMIUM (GLsizei width, GLsizei height,

[reveman, 2014/04/30 11:31:28]

while here, can you remove space between "CHROMIUM" and "("?

-                                GLenum internalformat)
+                                GLenum internalformat, GLenum usage)
 
     Allocate an image with width equal to <width> and height equal
     to <height> stored in format <internalformat>.
@@ -49,26 +51,25 @@ New Procedures and Functions
 
     INVALID_VALUE is generated if <width> or <height> is nonpositive.
 
+    INVALID_ENUM is generated if <usage> is not one of READ_WRITE and

[reveman, 2014/04/30 11:31:28]

CPU_READ_WRITE?

[alexst (slow to review), 2014/04/30 23:41:46]

GL_IMAGE_CPU_READ_WRITE_CHROMIUM to match IMAGE_ROWBYTES_CHROMIUM?

[reveman, 2014/05/01 12:06:37]

Yes, maybe even IMAGE_MAP_READ_WRITE or simply IMAGE_MAP is better? Would make
it a bit more clear that this affects whether Map/UnmapImage functions can be
used with the image. You can also make this a bit field if you like
"IMAGE_MAP_BIT_CHROMIUM | IMAGE_SCANOUT_BIT_CHROMIUM". I don't feel that
strongly about it though. Latest patch is fine with me in this regard if that's
what you prefer.

+    SCANOUT.
+
     void DestroyImageCHROMIUM (GLuint image_id)

[reveman, 2014/04/30 11:31:28]

please remove the space here too

 
     Frees the image previously allocated by a call to CreateImageCHROMIUM.
 
     INVALID_OPERATION is generated if <image_id> is not a valid image id.
 
-    void* MapImageCHROMIUM (GLuint image_id, GLenum access)
+    void* MapImageCHROMIUM (GLuint image_id)

[reveman, 2014/04/30 11:31:28]

remove space

 
     Returns a pointer to in the user memory for the application to modify
-    the image. <access> parameter defines if the user will read or write the
-    pixels.
+    the image. Returns null is the image was not created with READ_WRITE usage.

[reveman, 2014/04/30 11:31:28]

s/is/if/

hm, I prefer if we just make it illegal to call this on an image that was not
created for this type of usage so we can crash in debug builds if this happens. 

[alexst (slow to review), 2014/04/30 23:41:46]

Done.

 
     INVALID_OPERATION is generated if <image_id> is not a valid image id.
 
     INVALID_OPERATION is generated if the image was already mapped by a previous
     call to this method.
 
-    INVALID_ENUM is generated if <access> is not one of WRITE_ONLY, READ_ONLY
-    and READ_WRITE.
-
     void UnmapImageCHROMIUM (GLuint image_id)

[reveman, 2014/04/30 11:31:28]

and the space here, thanks :)

 
     Removes the mapping created by a call to MapImageCHROMIUM.