Change glimage to accept a type.

gpu/GLES2/extensions/CHROMIUM/CHROMIUM_map_image.txt

 Name
 
     CHROMIUM_map_image

[reveman, 2014/04/30 11:31:28]

"map" is awkward naming now that that is not necessarily supported. I think we
can just rename this to CHROMIUM_image. Alternatively we can move the
create/destroy parts of this extension into a new CHROMIUM_image_base extension
and cpu read/write, scanout can be provided using layered extensions. Not sure
that's worth it though. Benefit would be that it matches what we probably need
on the EGL side.

 
 Name Strings
 
     GL_CHROMIUM_map_image
 
 Version
 
     Last Modifed Date: May 9, 2013
 
 Dependencies
 
     OpenGL ES 2.0 is required.
 
 Overview
 
     This extension allows for more efficient uploading of texture data through
-    Chromium's OpenGL ES 2.0 implementation.
+    Chromium's OpenGL ES 2.0 implementation as well as enable hardware overlay
+    support by providing avility to create buffers capable of being scanned out

[reveman, 2014/04/30 11:31:28]

the ability

+    directly by the display controller.
 
     For security reasons Chromium accesses the GPU from a separate process. User
     processes are not allowed to access the GPU directly. This multi-process
     architechure has the advantage that GPU operations can be secured and
     pipelined but it has the disadvantage that all data that is going to be
     passed to GPU must first be made available to the separate GPU process.
 
     This extension helps the application directly allocate and access texture
     memory.
 
 Issues
 
     None
 
 New Tokens
 
     None

[reveman, 2014/04/30 11:31:28]

Can you add the enums to this section? including IMAGE_ROWBYTES_CHROMIUM

 
 New Procedures and Functions
 
     GLuint CreateImageCHROMIUM (GLsizei width, GLsizei height,

[reveman, 2014/04/30 11:31:28]

while here, can you remove space between "CHROMIUM" and "("?

-                                GLenum internalformat)
+                                GLenum internalformat, GLenum usage)
 
     Allocate an image with width equal to <width> and height equal
     to <height> stored in format <internalformat>.
 
     Returns a unique identifier for the allocated image that could be used
     in subsequent operations.
 
     INVALID_VALUE is generated if <width> or <height> is nonpositive.
 
+    INVALID_ENUM is generated if <usage> is not one of READ_WRITE and

[reveman, 2014/04/30 11:31:28]

CPU_READ_WRITE?

[alexst (slow to review), 2014/04/30 23:41:46]

GL_IMAGE_CPU_READ_WRITE_CHROMIUM to match IMAGE_ROWBYTES_CHROMIUM?

[reveman, 2014/05/01 12:06:37]

Yes, maybe even IMAGE_MAP_READ_WRITE or simply IMAGE_MAP is better? Would make
it a bit more clear that this affects whether Map/UnmapImage functions can be
used with the image. You can also make this a bit field if you like
"IMAGE_MAP_BIT_CHROMIUM | IMAGE_SCANOUT_BIT_CHROMIUM". I don't feel that
strongly about it though. Latest patch is fine with me in this regard if that's
what you prefer.

+    SCANOUT.
+
     void DestroyImageCHROMIUM (GLuint image_id)

[reveman, 2014/04/30 11:31:28]

please remove the space here too

 
     Frees the image previously allocated by a call to CreateImageCHROMIUM.
 
     INVALID_OPERATION is generated if <image_id> is not a valid image id.
 
-    void* MapImageCHROMIUM (GLuint image_id, GLenum access)
+    void* MapImageCHROMIUM (GLuint image_id)

[reveman, 2014/04/30 11:31:28]

remove space

 
     Returns a pointer to in the user memory for the application to modify
-    the image. <access> parameter defines if the user will read or write the
-    pixels.
+    the image. Returns null is the image was not created with READ_WRITE usage.

[reveman, 2014/04/30 11:31:28]

s/is/if/

hm, I prefer if we just make it illegal to call this on an image that was not
created for this type of usage so we can crash in debug builds if this happens. 

[alexst (slow to review), 2014/04/30 23:41:46]

Done.

 
     INVALID_OPERATION is generated if <image_id> is not a valid image id.
 
     INVALID_OPERATION is generated if the image was already mapped by a previous
     call to this method.
 
-    INVALID_ENUM is generated if <access> is not one of WRITE_ONLY, READ_ONLY
-    and READ_WRITE.
-
     void UnmapImageCHROMIUM (GLuint image_id)

[reveman, 2014/04/30 11:31:28]

and the space here, thanks :)

 
     Removes the mapping created by a call to MapImageCHROMIUM.
 
     Note that after calling UnmapImageCHROMIUM the application should assume
     that the memory returned by MapImageCHROMIUM is off limits and is no longer
     accessible by the application. Accessing it after calling
     UnmapImageCHROMIUM will produce undefined results.
 
     INVALID_OPERATION is generated if <image_id> is not a valid image id.
 
@@ skipping 15 matching lines @@
 
     None.
 
 New State
 
     None.
 
 Revision History
 
     5/9/2013    Documented the extension