Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: chrome/browser/previews/previews_infobar_delegate_unittest.cc

Issue 2557113004: Seperate reloads when reporting previews infobar dismissal (Closed)
Patch Set: megjablon comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/previews/previews_infobar_delegate_unittest.cc
diff --git a/chrome/browser/previews/previews_infobar_delegate_unittest.cc b/chrome/browser/previews/previews_infobar_delegate_unittest.cc
index af0ad75606bbe5408810dffdb362c19f5c3cf1bf..949258f616f204d9b2db9acd552e9678882639f3 100644
--- a/chrome/browser/previews/previews_infobar_delegate_unittest.cc
+++ b/chrome/browser/previews/previews_infobar_delegate_unittest.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/previews/previews_infobar_delegate.h"
#include <memory>
+#include <string>
#include "base/bind.h"
#include "base/bind_helpers.h"
@@ -25,8 +26,10 @@
#include "components/prefs/pref_registry_simple.h"
#include "components/proxy_config/proxy_config_pref_names.h"
#include "content/public/browser/web_contents.h"
+#include "content/public/common/referrer.h"
#include "content/public/test/web_contents_tester.h"
#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/page_transition_types.h"
#include "ui/base/window_open_disposition.h"
namespace {
@@ -137,6 +140,37 @@ TEST_F(PreviewsInfoBarDelegateUnitTest, InfobarTestNavigationDismissal) {
data_reduction_proxy::prefs::kLoFiLoadImagesPerSession));
}
+TEST_F(PreviewsInfoBarDelegateUnitTest, InfobarTestReloadDismissal) {
+ base::HistogramTester tester;
+
+ // Navigate to test URL, so we can reload later.
+ content::WebContentsTester::For(web_contents())
+ ->NavigateAndCommit(GURL(kTestUrl));
+
+ CreateInfoBar(PreviewsInfoBarDelegate::LOFI);
+
+ // Try showing a second infobar. Another should not be shown since the page
+ // has not navigated.
+ PreviewsInfoBarDelegate::Create(
+ web_contents(), PreviewsInfoBarDelegate::LOFI,
+ PreviewsInfoBarDelegate::OnDismissPreviewsInfobarCallback());
+ EXPECT_EQ(1U, infobar_service()->infobar_count());
+
+ // Navigate to test URL as a reload to dismiss the infobar.
+ controller().LoadURL(GURL(kTestUrl), content::Referrer(),
+ ui::PAGE_TRANSITION_RELOAD, std::string());
+ content::WebContentsTester::For(web_contents())->CommitPendingNavigation();
+
+ EXPECT_EQ(0U, infobar_service()->infobar_count());
+ EXPECT_FALSE(user_opt_out_.value());
+
+ tester.ExpectBucketCount(kUMAPreviewsInfoBarActionLoFi,
+ PreviewsInfoBarDelegate::INFOBAR_DISMISSED_BY_RELOAD,
+ 1);
+ EXPECT_EQ(0, drp_test_context_->pref_service()->GetInteger(
+ data_reduction_proxy::prefs::kLoFiLoadImagesPerSession));
+}
+
TEST_F(PreviewsInfoBarDelegateUnitTest, InfobarTestUserDismissal) {
base::HistogramTester tester;

Powered by Google App Engine
This is Rietveld 408576698