chrome/browser/previews/previews_infobar_delegate.cc - Issue 2557113004: Seperate reloads when reporting previews infobar dismissal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/previews/previews_infobar_delegate.cc

Issue 2557113004: Seperate reloads when reporting previews infobar dismissal (Closed)

Patch Set: megjablon comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/previews/previews_infobar_delegate.cc

diff --git a/chrome/browser/previews/previews_infobar_delegate.cc b/chrome/browser/previews/previews_infobar_delegate.cc

index 55ad0e3a4f03d5401e5097817e285a2dbaf4436c..8d24da5e37be46605c9447cb41fe4ad00dbf5109 100644

--- a/chrome/browser/previews/previews_infobar_delegate.cc

+++ b/chrome/browser/previews/previews_infobar_delegate.cc

@@ -103,7 +103,9 @@ int PreviewsInfoBarDelegate::GetIconId() const {

bool PreviewsInfoBarDelegate::ShouldExpire(

const NavigationDetails& details) const {

- RecordPreviewsInfoBarAction(infobar_type_, INFOBAR_DISMISSED_BY_NAVIGATION);

+ RecordPreviewsInfoBarAction(

+ infobar_type_, details.is_reload ? INFOBAR_DISMISSED_BY_RELOAD

+ : INFOBAR_DISMISSED_BY_NAVIGATION);

return InfoBarDelegate::ShouldExpire(details);

}