Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: third_party/WebKit/Source/core/frame/RemoteFrame.cpp

Issue 2557063002: Upgrade Insecure Requests: bugfixes, tests, and support for OOPIF.
Patch Set: Addressed comments (@nasko #2). Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/RemoteFrame.cpp
diff --git a/third_party/WebKit/Source/core/frame/RemoteFrame.cpp b/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
index 4abb8f84a22cad754e0805663eaaa4a7ec210f14..9ad838ff155064ea6845fd085355fafeaf6d043c 100644
--- a/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
+++ b/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
@@ -66,7 +66,10 @@ void RemoteFrame::navigate(Document& originDocument,
const KURL& url,
bool replaceCurrentItem,
UserGestureStatus userGestureStatus) {
- FrameLoadRequest frameRequest(&originDocument, url);
+ KURL upgradedURL(url);
+ upgradeInsecureRequest(upgradedURL, originDocument);
+
+ FrameLoadRequest frameRequest(&originDocument, upgradedURL);
frameRequest.setReplacesCurrentItem(replaceCurrentItem);
frameRequest.resourceRequest().setHasUserGesture(userGestureStatus ==
UserGestureStatus::Active);

Powered by Google App Engine
This is Rietveld 408576698