third_party/WebKit/Source/core/frame/LocalFrame.cpp - Issue 2557063002: Upgrade Insecure Requests: bugfixes, tests, and support for OOPIF.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2557063002: Upgrade Insecure Requests: bugfixes, tests, and support for OOPIF.

Patch Set: Addressed comments (@nasko #2). Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

index fce55762b41d60740ebe853b59143a1b8a45b3a7..a1792ed41a253d87485f13213c3451589130f1be 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

@@ -361,8 +361,11 @@ void LocalFrame::navigate(Document& originDocument,

const KURL& url,

bool replaceCurrentItem,

UserGestureStatus userGestureStatus) {

+ KURL upgradedURL(url);

+ upgradeInsecureRequest(upgradedURL, originDocument);

m_navigationScheduler->scheduleLocationChange(

- &originDocument, url.getString(), replaceCurrentItem);

+ &originDocument, upgradedURL.getString(), replaceCurrentItem);

}

void LocalFrame::navigate(const FrameLoadRequest& request) {