Remove ContextLifecycleObserver from NotificationManager

third_party/WebKit/Source/modules/notifications/NotificationManager.h

Index: third_party/WebKit/Source/modules/notifications/NotificationManager.h
diff --git a/third_party/WebKit/Source/modules/notifications/NotificationManager.h b/third_party/WebKit/Source/modules/notifications/NotificationManager.h
index 6b4042c446e8969b0271d79ee9214d2342a7dfc5..37bafc925943dfc316665bf117dee9eeb7dc3674 100644
--- a/third_party/WebKit/Source/modules/notifications/NotificationManager.h
+++ b/third_party/WebKit/Source/modules/notifications/NotificationManager.h
@@ -5,7 +5,6 @@
 #ifndef NotificationManager_h
 #define NotificationManager_h
 
-#include "core/dom/ContextLifecycleObserver.h"
 #include "core/dom/ExecutionContext.h"
 #include "public/platform/modules/notifications/notification_service.mojom-blink.h"
 #include "public/platform/modules/permissions/permission.mojom-blink.h"
@@ -25,7 +24,6 @@ class ScriptState;
 // TODO(peter): Make the NotificationManager responsible for resource loading.
 class NotificationManager final
     : public GarbageCollectedFinalized<NotificationManager>,
-      public ContextLifecycleObserver,
       public Supplement<ExecutionContext> {
   USING_GARBAGE_COLLECTED_MIXIN(NotificationManager);
   WTF_MAKE_NONCOPYABLE(NotificationManager);
@@ -38,19 +36,16 @@ class NotificationManager final
 
   // Returns the notification permission status of the current origin. This
   // method is synchronous to support the Notification.permission getter.
-  mojom::blink::PermissionStatus permissionStatus();
+  mojom::blink::PermissionStatus permissionStatus(ExecutionContext*);

[Peter Beverloo, 2016/12/07 13:25:36]

For future reference -

All potential methods that fit in this class (which supersedes the
WebNotificationManager) will need access to at least the SecurityOrigin, that
lives off ExecutionContext.

Is it safe to store a RefPtr<> to the SecurityOrigin set once in the
constructor, retrieved from the ExecutionContext that we supplement, and use
that instead of passing it explicitly to every call?

[haraken, 2016/12/07 15:27:13]

It should be safe. The fact that NotificationManager is
Supplement<ExecutionContext> means that NotificationManager is "a part of"
ExecutionContext. The ExecutionContext should not change over the lifetime of
NotificationManager.

 
   ScriptPromise requestPermission(
       ScriptState*,
       NotificationPermissionCallback* deprecatedCallback);
 
-  // ContextLifecycleObserver interface.
-  void contextDestroyed() override;
-
   DECLARE_VIRTUAL_TRACE();
 
  private:
-  explicit NotificationManager(ExecutionContext*);
+  NotificationManager();
 
   void onPermissionRequestComplete(ScriptPromiseResolver*,
                                    NotificationPermissionCallback*,