Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.cpp

Issue 2557033002: Remove ContextLifecycleObserver from NotificationManager (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/notifications/Notification.cpp
diff --git a/third_party/WebKit/Source/modules/notifications/Notification.cpp b/third_party/WebKit/Source/modules/notifications/Notification.cpp
index 980b5ac8521881772ebd762e78bf2cc255fc922d..2090e9a08c3feef9ed595173563c5e4ee05f9307 100644
--- a/third_party/WebKit/Source/modules/notifications/Notification.cpp
+++ b/third_party/WebKit/Source/modules/notifications/Notification.cpp
@@ -155,7 +155,8 @@ void Notification::schedulePrepareShow() {
void Notification::prepareShow() {
DCHECK_EQ(m_state, State::Loading);
- if (NotificationManager::from(getExecutionContext())->permissionStatus() !=
+ if (NotificationManager::from(getExecutionContext())
+ ->permissionStatus(getExecutionContext()) !=
mojom::blink::PermissionStatus::GRANTED) {
dispatchErrorEvent();
return;
@@ -355,7 +356,7 @@ String Notification::permissionString(
String Notification::permission(ExecutionContext* context) {
return permissionString(
- NotificationManager::from(context)->permissionStatus());
+ NotificationManager::from(context)->permissionStatus(context));
}
ScriptPromise Notification::requestPermission(

Powered by Google App Engine
This is Rietveld 408576698