third_party/WebKit/Source/core/dom/TaskRunnerHelper.h - Issue 2556993005: [blink] Split TaskType::Internal into InternalTimer and InternalLoading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/TaskRunnerHelper.h

Issue 2556993005: [blink] Split TaskType::Internal into InternalTimer and InternalLoading. (Closed)

Patch Set: addressed skyostil@'s comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/TaskRunnerHelper.h

diff --git a/third_party/WebKit/Source/core/dom/TaskRunnerHelper.h b/third_party/WebKit/Source/core/dom/TaskRunnerHelper.h

index ffd59c38eaf5bc31f6a78ed477dcffb7f95686d7..798305ddb04852a21934c8e89d76803912909c06 100644

--- a/third_party/WebKit/Source/core/dom/TaskRunnerHelper.h

+++ b/third_party/WebKit/Source/core/dom/TaskRunnerHelper.h

@@ -37,7 +37,11 @@ enum class TaskType : unsigned {

// Other internal tasks that cannot fit any of the above task runners

// can be posted here, but the usage is not encouraged. The task runner

// may be throttled.

- Internal,

+ //

+ // InternalLoading type should be used for all tasks associated with

+ // loading page content, InternalTimer should be used for all other purposes.

+ InternalTimer,

+ InternalLoading,

haraken 2016/12/09 00:04:27 Shall we rename these to UnspecedTimerTask and Uns

// Tasks that must not be throttled should be posted here, but the usage

// should be very limited.