Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2556993005: [blink] Split TaskType::Internal into InternalTimer and InternalLoading. (Closed)
Patch Set: addressed skyostil@'s comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 3635b9b0180081041d5b80f061a2a4a92addb803..83ad1962a19c20f81b706693723f1e2808b6d869 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -420,7 +420,7 @@ Document::Document(const DocumentInit& initializer,
m_compatibilityModeLocked(false),
m_hasAutofocused(false),
m_clearFocusedElementTimer(
- TaskRunnerHelper::get(TaskType::Internal, this),
+ TaskRunnerHelper::get(TaskType::InternalTimer, this),
this,
&Document::clearFocusedElementTimerFired),
m_domTreeVersion(++s_globalTreeVersion),
@@ -441,7 +441,7 @@ Document::Document(const DocumentInit& initializer,
m_throwOnDynamicMarkupInsertionCount(0),
m_markers(new DocumentMarkerController(*this)),
m_updateFocusAppearanceTimer(
- TaskRunnerHelper::get(TaskType::Internal, this),
+ TaskRunnerHelper::get(TaskType::InternalTimer, this),
this,
&Document::updateFocusAppearanceTimerFired),
m_cssTarget(nullptr),
@@ -468,22 +468,23 @@ Document::Document(const DocumentInit& initializer,
m_loadEventDelayTimer(TaskRunnerHelper::get(TaskType::Networking, this),
this,
&Document::loadEventDelayTimerFired),
- m_pluginLoadingTimer(TaskRunnerHelper::get(TaskType::Internal, this),
- this,
- &Document::pluginLoadingTimerFired),
+ m_pluginLoadingTimer(
+ TaskRunnerHelper::get(TaskType::InternalLoading, this),
+ this,
+ &Document::pluginLoadingTimerFired),
m_documentTiming(*this),
m_writeRecursionIsTooDeep(false),
m_writeRecursionDepth(0),
m_registrationContext(initializer.registrationContext(this)),
m_elementDataCacheClearTimer(
- TaskRunnerHelper::get(TaskType::Internal, this),
+ TaskRunnerHelper::get(TaskType::InternalTimer, this),
this,
&Document::elementDataCacheClearTimerFired),
m_timeline(DocumentTimeline::create(this)),
m_compositorPendingAnimations(new CompositorPendingAnimations()),
m_templateDocumentHost(nullptr),
m_didAssociateFormControlsTimer(
- TaskRunnerHelper::get(TaskType::Internal, this),
+ TaskRunnerHelper::get(TaskType::InternalLoading, this),
this,
&Document::didAssociateFormControlsTimerFired),
m_timers(TaskRunnerHelper::get(TaskType::Timer, this)->clone()),
@@ -4353,7 +4354,7 @@ void Document::sendSensitiveInputVisibility() {
return;
m_sensitiveInputVisibilityTask =
- TaskRunnerHelper::get(TaskType::Internal, this)
+ TaskRunnerHelper::get(TaskType::InternalLoading, this)
->postCancellableTask(
BLINK_FROM_HERE,
WTF::bind(&Document::sendSensitiveInputVisibilityInternal,

Powered by Google App Engine
This is Rietveld 408576698