Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: third_party/WebKit/Source/core/dom/TaskRunnerHelper.h

Issue 2556993005: [blink] Split TaskType::Internal into InternalTimer and InternalLoading. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/TaskRunnerHelper.h
diff --git a/third_party/WebKit/Source/core/dom/TaskRunnerHelper.h b/third_party/WebKit/Source/core/dom/TaskRunnerHelper.h
index ffd59c38eaf5bc31f6a78ed477dcffb7f95686d7..46da2a3acfc342820f14aa1956301dcf088cd547 100644
--- a/third_party/WebKit/Source/core/dom/TaskRunnerHelper.h
+++ b/third_party/WebKit/Source/core/dom/TaskRunnerHelper.h
@@ -37,7 +37,12 @@ enum class TaskType : unsigned {
// Other internal tasks that cannot fit any of the above task runners
// can be posted here, but the usage is not encouraged. The task runner
// may be throttled.
- Internal,
+ //
+ // InternalLoading should be related to loading tasks, which can cause
+ // regressions in page load time when throttled in the background.
Sami 2016/12/08 17:05:08 I think this is worded a bit too negatively. Maybe
altimin 2016/12/08 17:47:40 Done.
+ // InternalTimer should be used for all other purposes.
+ InternalTimer,
+ InternalLoading,
// Tasks that must not be throttled should be posted here, but the usage
// should be very limited.

Powered by Google App Engine
This is Rietveld 408576698