Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Side by Side Diff: third_party/WebKit/Source/core/dom/TaskRunnerHelper.h

Issue 2556993005: [blink] Split TaskType::Internal into InternalTimer and InternalLoading. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TaskRunnerHelper_h 5 #ifndef TaskRunnerHelper_h
6 #define TaskRunnerHelper_h 6 #define TaskRunnerHelper_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "wtf/Allocator.h" 9 #include "wtf/Allocator.h"
10 #include "wtf/HashTraits.h" 10 #include "wtf/HashTraits.h"
(...skipping 19 matching lines...) Expand all
30 Microtask, 30 Microtask,
31 Timer, 31 Timer,
32 RemoteEvent, 32 RemoteEvent,
33 WebSocket, 33 WebSocket,
34 PostedMessage, 34 PostedMessage,
35 UnshippedPortMessage, 35 UnshippedPortMessage,
36 36
37 // Other internal tasks that cannot fit any of the above task runners 37 // Other internal tasks that cannot fit any of the above task runners
38 // can be posted here, but the usage is not encouraged. The task runner 38 // can be posted here, but the usage is not encouraged. The task runner
39 // may be throttled. 39 // may be throttled.
40 Internal, 40 //
41 // InternalLoading should be related to loading tasks, which can cause
42 // regressions in page load time when throttled in the background.
Sami 2016/12/08 17:05:08 I think this is worded a bit too negatively. Maybe
altimin 2016/12/08 17:47:40 Done.
43 // InternalTimer should be used for all other purposes.
44 InternalTimer,
45 InternalLoading,
41 46
42 // Tasks that must not be throttled should be posted here, but the usage 47 // Tasks that must not be throttled should be posted here, but the usage
43 // should be very limited. 48 // should be very limited.
44 Unthrottled, 49 Unthrottled,
45 50
46 // Tasks that any other TaskType is not assigned to. This should be 51 // Tasks that any other TaskType is not assigned to. This should be
47 // transitional and should be removed. 52 // transitional and should be removed.
48 Unspecified, 53 Unspecified,
49 }; 54 };
50 55
(...skipping 15 matching lines...) Expand all
66 public: 71 public:
67 static WebTaskRunner* get(TaskType, LocalFrame*); 72 static WebTaskRunner* get(TaskType, LocalFrame*);
68 static WebTaskRunner* get(TaskType, Document*); 73 static WebTaskRunner* get(TaskType, Document*);
69 static WebTaskRunner* get(TaskType, ExecutionContext*); 74 static WebTaskRunner* get(TaskType, ExecutionContext*);
70 static WebTaskRunner* get(TaskType, ScriptState*); 75 static WebTaskRunner* get(TaskType, ScriptState*);
71 }; 76 };
72 77
73 } // namespace blink 78 } // namespace blink
74 79
75 #endif 80 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698