Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2556993002: Experiment with AVX optimizations for FMAC, FMUL operations.

Created:
4 years ago by DaleCurtis
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Experiment with AVX optimizations for FMAC, FMUL operations. Tests how AVX (256-bit operations) fair versus our existing SSE based optimizations (128-bit). The answer is not well! vector_math_fmac: unoptimized= 521.3478928421541 runs/ms vector_math_fmac: sse_unaligned= 512.7810681229649 runs/ms vector_math_fmac: sse_aligned= 524.1914347119567 runs/ms vector_math_fmac: avx_unaligned= 468.17904102887024 runs/ms vector_math_fmac: avx_aligned= 453.4674387705591 runs/ms vector_math_fmul: unoptimized= 664.2245344616294 runs/ms vector_math_fmul: sse_unaligned= 666.4911573285701 runs/ms vector_math_fmul: sse_aligned= 653.6695373653849 runs/ms vector_math_fmul: avx_unaligned= 613.5270442721115 runs/ms vector_math_fmul: avx_aligned= 586.0634120611851 runs/ms FMA operations for FMAC and dot products (used in SincResampler and WSOLA would probably fare better, but I don't have a machine which can test these). BUG=none TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+782 lines, -555 lines) Patch
M media/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
M media/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/audio_bus.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_parameters.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/media.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/base/sinc_resampler.h View 3 chunks +4 lines, -22 lines 0 comments Download
M media/base/sinc_resampler.cc View 4 chunks +2 lines, -100 lines 0 comments Download
D media/base/sinc_resampler_perftest.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M media/base/sinc_resampler_unittest.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M media/base/vector_math.h View 2 chunks +27 lines, -8 lines 0 comments Download
M media/base/vector_math.cc View 8 chunks +235 lines, -43 lines 0 comments Download
A media/base/vector_math_avx.cc View 1 chunk +107 lines, -0 lines 0 comments Download
M media/base/vector_math_perftest.cc View 5 chunks +150 lines, -44 lines 0 comments Download
M media/base/vector_math_testing.h View 1 chunk +45 lines, -14 lines 0 comments Download
M media/base/vector_math_unittest.cc View 10 chunks +189 lines, -147 lines 0 comments Download
M media/filters/wsola_internals.cc View 2 chunks +4 lines, -55 lines 0 comments Download

Depends on Patchset:

Powered by Google App Engine
This is Rietveld 408576698