Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2552203003: Revert debugging checks from SincResampler; no crashes found. (Closed)

Created:
4 years ago by DaleCurtis
Modified:
4 years ago
Reviewers:
watk
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert debugging checks from SincResampler; no crashes found. None of the crash checks were hit, so this seems to imply that we're always dealing with non-nan values for the virtual index. I'm not sure what's gone awry, but have simplified the while loop here (and retested locally on ARM, x86, performance is actually improved on modern ARM devices and slightly negative on pre-64bit ARM devices). Results from media_perftests for AudioConverterPerfTest.ConvertBenchmark Z620 (X86): ~35% faster. N5X (ARM64): ~3.7% faster. N4 (ARM): ~0.81% slower. BUG=663814 TEST=none Committed: https://crrev.com/4147f786f38d0af6f19d62f73dc5dfb67d6c3a5a Cr-Commit-Position: refs/heads/master@{#436852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -47 lines) Patch
M media/base/sinc_resampler.cc View 7 chunks +17 lines, -47 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
DaleCurtis
4 years ago (2016-12-07 00:49:00 UTC) #2
watk
lgtm
4 years ago (2016-12-07 01:30:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552203003/1
4 years ago (2016-12-07 01:34:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 03:42:07 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-07 03:44:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4147f786f38d0af6f19d62f73dc5dfb67d6c3a5a
Cr-Commit-Position: refs/heads/master@{#436852}

Powered by Google App Engine
This is Rietveld 408576698