Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2556843002: Converts WindowManagerTest.OpenWindow to aura-mus (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
Reviewers:
Tom Sepez, sadrul
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converts WindowManagerTest.OpenWindow to aura-mus BUG=669964 TEST=covered by test R=sadrul@chromium.org, tsepez@chromium.org Committed: https://crrev.com/b87f0a13aa4cdfdf0afbfd3f44ff19f3831c9974 Cr-Commit-Position: refs/heads/master@{#436708}

Patch Set 1 #

Patch Set 2 : not relative #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -24 lines) Patch
M ash/mus/window_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/mus/window_manager_unittest.cc View 2 chunks +63 lines, -23 lines 0 comments Download
M mash/unittests_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
sky
4 years ago (2016-12-06 17:54:12 UTC) #3
Tom Sepez
RS LGTM
4 years ago (2016-12-06 17:54:15 UTC) #5
sadrul
lgtm
4 years ago (2016-12-06 20:31:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556843002/20001
4 years ago (2016-12-06 20:39:18 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 20:46:16 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-06 20:49:18 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b87f0a13aa4cdfdf0afbfd3f44ff19f3831c9974
Cr-Commit-Position: refs/heads/master@{#436708}

Powered by Google App Engine
This is Rietveld 408576698