Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2301)

Unified Diff: ash/mus/window_manager.cc

Issue 2556843002: Converts WindowManagerTest.OpenWindow to aura-mus (Closed)
Patch Set: not relative Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/mus/window_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/window_manager.cc
diff --git a/ash/mus/window_manager.cc b/ash/mus/window_manager.cc
index d65aad95cc2956f4483abc724410dff025e79d4c..77d66e7cda66d438c8778cb2869b1986efee59be 100644
--- a/ash/mus/window_manager.cc
+++ b/ash/mus/window_manager.cc
@@ -400,6 +400,11 @@ bool WindowManager::OnWmSetProperty(
aura::Window* WindowManager::OnWmCreateTopLevelWindow(
ui::mojom::WindowType window_type,
std::map<std::string, std::vector<uint8_t>>* properties) {
+ if (window_type == ui::mojom::WindowType::UNKNOWN) {
+ LOG(WARNING) << "Request to create top level of unknown type, failing";
+ return nullptr;
+ }
+
return NewTopLevelWindow(window_type, properties);
}
« no previous file with comments | « no previous file | ash/mus/window_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698