Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2556833002: Make LabelButton::SetFontList protected. (Closed)

Created:
4 years ago by Evan Stade
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make LabelButton::SetFontList protected. The last public use of it is part of the pre-MD profile switcher. BUG=633986 Committed: https://crrev.com/19d351e0f8ff0472bb33279570dc569bfe6128cb Cr-Commit-Position: refs/heads/master@{#437967}

Patch Set 1 #

Patch Set 2 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M chrome/browser/ui/views/profiles/new_avatar_button.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/label_button.h View 2 chunks +5 lines, -4 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 2 chunks +17 lines, -16 lines 0 comments Download
M ui/views/controls/button/label_button_unittest.cc View 1 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Evan Stade
4 years ago (2016-12-12 17:04:54 UTC) #10
sky
LGTM
4 years ago (2016-12-12 17:45:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556833002/20001
4 years ago (2016-12-12 17:52:38 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 00:36:12 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-13 00:38:09 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/19d351e0f8ff0472bb33279570dc569bfe6128cb
Cr-Commit-Position: refs/heads/master@{#437967}

Powered by Google App Engine
This is Rietveld 408576698