Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2556813002:
Record executable version details to stability file (Closed)
|
Created:
4 years ago by manzagop (departed) Modified:
4 years ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRecord executable version details to stability file
BUG=620813
Committed: https://crrev.com/09c0c274ade68914487c187b2e99ab85f43b99a0
Cr-Commit-Position: refs/heads/master@{#437719}
Patch Set 1 #
Total comments: 8
Patch Set 2 : Address comments #
Total comments: 2
Patch Set 3 : Address bcwhite's comments #Patch Set 4 : Merge #
Messages
Total messages: 35 (22 generated)
The CQ bit was checked by manzagop@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
manzagop@chromium.org changed reviewers: + bcwhite@chromium.org
Hi Brian, Please have a look! Thanks, Pierre
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2556813002/diff/1/chrome/browser/chrome_brows... File chrome/browser/chrome_browser_field_trials_desktop.cc (right): https://codereview.chromium.org/2556813002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_field_trials_desktop.cc:130: global_data.SetString(browser_watcher::kStabilityProduct, Feel free to create a SetString method inside ActivityUserData that takes a StringPiece16 and converts it to UTF8 internally. https://codereview.chromium.org/2556813002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_field_trials_desktop.cc:139: global_data.SetString(browser_watcher::kStabilityPlatform, "Win32"); Shouldn't these be x86 and x64, given that the defined symbols are CPU architectures and not strictly Windows architectures? https://codereview.chromium.org/2556813002/diff/1/components/browser_watcher/... File components/browser_watcher/stability_data_names.cc (right): https://codereview.chromium.org/2556813002/diff/1/components/browser_watcher/... components/browser_watcher/stability_data_names.cc:9: const char kStabilityChannel[] = "channel"; Since these are global, is it worth having the strings indicate such? e.g. Chrome-Channel Chrome-Platform etc. Or similar. Just wondering if there might end up being, for example, a "version" of something else that is also global.
The CQ bit was checked by manzagop@chromium.org to run a CQ dry run
Thanks! Another look? https://codereview.chromium.org/2556813002/diff/1/chrome/browser/chrome_brows... File chrome/browser/chrome_browser_field_trials_desktop.cc (right): https://codereview.chromium.org/2556813002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_field_trials_desktop.cc:130: global_data.SetString(browser_watcher::kStabilityProduct, On 2016/12/06 19:28:43, bcwhite wrote: > Feel free to create a SetString method inside ActivityUserData that takes a > StringPiece16 and converts it to UTF8 internally. Done. https://codereview.chromium.org/2556813002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_field_trials_desktop.cc:139: global_data.SetString(browser_watcher::kStabilityPlatform, "Win32"); On 2016/12/06 19:28:43, bcwhite wrote: > Shouldn't these be x86 and x64, given that the defined symbols are CPU > architectures and not strictly Windows architectures? Yeah... These are the "platform" strings that the crash frontend expects from windows clients. In fact, the above way of getting the product name/version/etc is also windows specific. https://codereview.chromium.org/2556813002/diff/1/components/browser_watcher/... File components/browser_watcher/stability_data_names.cc (right): https://codereview.chromium.org/2556813002/diff/1/components/browser_watcher/... components/browser_watcher/stability_data_names.cc:9: const char kStabilityChannel[] = "channel"; On 2016/12/06 19:28:43, bcwhite wrote: > Since these are global, is it worth having the strings indicate such? e.g. > Chrome-Channel > Chrome-Platform > etc. > > Or similar. Just wondering if there might end up being, for example, a > "version" of something else that is also global. I think I prefer keeping these short and we can qualify more the more specific ones. Sg?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2556813002/diff/1/chrome/browser/chrome_brows... File chrome/browser/chrome_browser_field_trials_desktop.cc (right): https://codereview.chromium.org/2556813002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_field_trials_desktop.cc:139: global_data.SetString(browser_watcher::kStabilityPlatform, "Win32"); On 2016/12/06 21:39:03, manzagop wrote: > On 2016/12/06 19:28:43, bcwhite wrote: > > Shouldn't these be x86 and x64, given that the defined symbols are CPU > > architectures and not strictly Windows architectures? > > Yeah... These are the "platform" strings that the crash frontend expects from > windows clients. In fact, the above way of getting the product name/version/etc > is also windows specific. Acknowledged. https://codereview.chromium.org/2556813002/diff/1/components/browser_watcher/... File components/browser_watcher/stability_data_names.cc (right): https://codereview.chromium.org/2556813002/diff/1/components/browser_watcher/... components/browser_watcher/stability_data_names.cc:9: const char kStabilityChannel[] = "channel"; On 2016/12/06 21:39:03, manzagop wrote: > On 2016/12/06 19:28:43, bcwhite wrote: > > Since these are global, is it worth having the strings indicate such? e.g. > > Chrome-Channel > > Chrome-Platform > > etc. > > > > Or similar. Just wondering if there might end up being, for example, a > > "version" of something else that is also global. > > I think I prefer keeping these short and we can qualify more the more specific > ones. Sg? Your call. https://codereview.chromium.org/2556813002/diff/20001/base/debug/activity_tra... File base/debug/activity_tracker.h (right): https://codereview.chromium.org/2556813002/diff/20001/base/debug/activity_tra... base/debug/activity_tracker.h:337: SetString(name, base::UTF16ToUTF8(value)); This module is part of base so you can remove the base:: qualifier.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by manzagop@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks! https://codereview.chromium.org/2556813002/diff/20001/base/debug/activity_tra... File base/debug/activity_tracker.h (right): https://codereview.chromium.org/2556813002/diff/20001/base/debug/activity_tra... base/debug/activity_tracker.h:337: SetString(name, base::UTF16ToUTF8(value)); On 2016/12/06 22:37:32, bcwhite wrote: > This module is part of base so you can remove the base:: qualifier. Done.
manzagop@chromium.org changed reviewers: + jwd@chromium.org
Hi Jesse! Could you have an OWNERS' look at chrome\browser\chrome_browser_field_trials_desktop.cc? Thanks! Pierre
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Thanks for the review!
The CQ bit was checked by manzagop@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bcwhite@chromium.org Link to the patchset: https://codereview.chromium.org/2556813002/#ps40001 (title: "Address bcwhite's comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by manzagop@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bcwhite@chromium.org, jwd@chromium.org Link to the patchset: https://codereview.chromium.org/2556813002/#ps60001 (title: "Merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481324084535560,
"parent_rev": "e8f9ba1bc4ad3088877a87443ce19b103268ec17", "commit_rev":
"d90b8a37cd28fa908bc6c349dfbe14c200a7d548"}
Message was sent while issue was closed.
Description was changed from ========== Record executable version details to stability file BUG=620813 ========== to ========== Record executable version details to stability file BUG=620813 Review-Url: https://codereview.chromium.org/2556813002 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Record executable version details to stability file BUG=620813 Review-Url: https://codereview.chromium.org/2556813002 ========== to ========== Record executable version details to stability file BUG=620813 Committed: https://crrev.com/09c0c274ade68914487c187b2e99ab85f43b99a0 Cr-Commit-Position: refs/heads/master@{#437719} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/09c0c274ade68914487c187b2e99ab85f43b99a0 Cr-Commit-Position: refs/heads/master@{#437719} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
