Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: test/cctest/test-macro-assembler-mips64.cc

Issue 2556793003: MIPS[64]: Fix `MIPS: Improve Float(32|64)(Max|Min)`. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-macro-assembler-mips64.cc
diff --git a/test/cctest/test-macro-assembler-mips64.cc b/test/cctest/test-macro-assembler-mips64.cc
index eb706d5cade81442f48c30138a1c092a30233629..5ee06b45d590c8063933b8d23fcf54d6d6ab56d6 100644
--- a/test/cctest/test-macro-assembler-mips64.cc
+++ b/test/cctest/test-macro-assembler-mips64.cc
@@ -2010,26 +2010,32 @@ static ::F4 GenerateMacroFloat32MinMax(MacroAssembler* masm) {
__ bind(&ool_min_abc);
__ Float32MinOutOfLine(a, b, c);
__ b(&done_min_abc);
+ __ nop();
ivica.bogosavljevic 2016/12/07 15:05:04 you shouldn't use b() outside of MacroAssembler, u
Ilija.Pavlovic1 2016/12/08 13:50:06 Using Branch macros will be applied also on macro-
__ bind(&ool_min_aab);
__ Float32MinOutOfLine(a, a, b);
__ b(&done_min_aab);
+ __ nop();
__ bind(&ool_min_aba);
__ Float32MinOutOfLine(a, b, a);
__ b(&done_min_aba);
+ __ nop();
__ bind(&ool_max_abc);
__ Float32MaxOutOfLine(a, b, c);
__ b(&done_max_abc);
+ __ nop();
__ bind(&ool_max_aab);
__ Float32MaxOutOfLine(a, a, b);
__ b(&done_max_aab);
+ __ nop();
__ bind(&ool_max_aba);
__ Float32MaxOutOfLine(a, b, a);
__ b(&done_max_aba);
+ __ nop();
CodeDesc desc;
masm->GetCode(&desc);
@@ -2153,26 +2159,32 @@ static ::F4 GenerateMacroFloat64MinMax(MacroAssembler* masm) {
__ bind(&ool_min_abc);
__ Float64MinOutOfLine(a, b, c);
__ b(&done_min_abc);
+ __ nop();
__ bind(&ool_min_aab);
__ Float64MinOutOfLine(a, a, b);
__ b(&done_min_aab);
+ __ nop();
__ bind(&ool_min_aba);
__ Float64MinOutOfLine(a, b, a);
__ b(&done_min_aba);
+ __ nop();
__ bind(&ool_max_abc);
__ Float64MaxOutOfLine(a, b, c);
__ b(&done_max_abc);
+ __ nop();
__ bind(&ool_max_aab);
__ Float64MaxOutOfLine(a, a, b);
__ b(&done_max_aab);
+ __ nop();
__ bind(&ool_max_aba);
__ Float64MaxOutOfLine(a, b, a);
__ b(&done_max_aba);
+ __ nop();
CodeDesc desc;
masm->GetCode(&desc);
« src/crankshaft/mips64/lithium-codegen-mips64.cc ('K') | « test/cctest/test-macro-assembler-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698