MIPS[64]: Fix `MIPS: Improve Float(32|64)(Max|Min)`.

test/cctest/test-macro-assembler-mips64.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1992 matching lines @@
 
 #undef FLOAT_MIN_MAX
 
   __ jr(ra);
   __ nop();
 
   // Generate out-of-line cases.
   __ bind(&ool_min_abc);
   __ Float32MinOutOfLine(a, b, c);
   __ b(&done_min_abc);
+  __ nop();

[ivica.bogosavljevic, 2016/12/07 15:05:04]

you shouldn't use b() outside of MacroAssembler, use Branch instead and you will
not need Nop

[Ilija.Pavlovic1, 2016/12/08 13:50:06]

Using Branch macros will be applied also on macro-assembler-mips[64].cc files.

Done.

 
   __ bind(&ool_min_aab);
   __ Float32MinOutOfLine(a, a, b);
   __ b(&done_min_aab);
+  __ nop();
 
   __ bind(&ool_min_aba);
   __ Float32MinOutOfLine(a, b, a);
   __ b(&done_min_aba);
+  __ nop();
 
   __ bind(&ool_max_abc);
   __ Float32MaxOutOfLine(a, b, c);
   __ b(&done_max_abc);
+  __ nop();
 
   __ bind(&ool_max_aab);
   __ Float32MaxOutOfLine(a, a, b);
   __ b(&done_max_aab);
+  __ nop();
 
   __ bind(&ool_max_aba);
   __ Float32MaxOutOfLine(a, b, a);
   __ b(&done_max_aba);
+  __ nop();
 
   CodeDesc desc;
   masm->GetCode(&desc);
   Handle<Code> code = masm->isolate()->factory()->NewCode(
       desc, Code::ComputeFlags(Code::STUB), Handle<Code>());
 #ifdef DEBUG
   OFStream os(stdout);
   code->Print(os);
 #endif
   return FUNCTION_CAST<::F4>(code->entry());
@@ skipping 103 matching lines @@
 
 #undef FLOAT_MIN_MAX
 
   __ jr(ra);
   __ nop();
 
   // Generate out-of-line cases.
   __ bind(&ool_min_abc);
   __ Float64MinOutOfLine(a, b, c);
   __ b(&done_min_abc);
+  __ nop();
 
   __ bind(&ool_min_aab);
   __ Float64MinOutOfLine(a, a, b);
   __ b(&done_min_aab);
+  __ nop();
 
   __ bind(&ool_min_aba);
   __ Float64MinOutOfLine(a, b, a);
   __ b(&done_min_aba);
+  __ nop();
 
   __ bind(&ool_max_abc);
   __ Float64MaxOutOfLine(a, b, c);
   __ b(&done_max_abc);
+  __ nop();
 
   __ bind(&ool_max_aab);
   __ Float64MaxOutOfLine(a, a, b);
   __ b(&done_max_aab);
+  __ nop();
 
   __ bind(&ool_max_aba);
   __ Float64MaxOutOfLine(a, b, a);
   __ b(&done_max_aba);
+  __ nop();
 
   CodeDesc desc;
   masm->GetCode(&desc);
   Handle<Code> code = masm->isolate()->factory()->NewCode(
       desc, Code::ComputeFlags(Code::STUB), Handle<Code>());
 #ifdef DEBUG
   OFStream os(stdout);
   code->Print(os);
 #endif
   return FUNCTION_CAST<::F4>(code->entry());
@@ skipping 62 matching lines @@
 
   CHECK_MINMAX(0.0, nan_a, nan_a, nan_a);
   CHECK_MINMAX(nan_a, 0.0, nan_a, nan_a);
   CHECK_MINMAX(nan_a, nan_b, nan_a, nan_a);
   CHECK_MINMAX(nan_b, nan_a, nan_b, nan_b);
 
 #undef CHECK_MINMAX
 }
 
 #undef __