MIPS[64]: Fix `MIPS: Improve Float(32|64)(Max|Min)`.

MIPS[64]: Fix `MIPS: Improve Float(32|64)(Max|Min)`.

Fix 7a6f294ffe8e9cc98e266238ec5cd0aa74524c4a.

The first correction enables correct execution DoMathMinMax when two
input registers are the same register.
The second correction adds NOP instructions after branch instructions
in tests macro_float_minmaxf(32|64).

TEST=cctest/test-macro-assembler-mips[64]/macro_float_minmax_f32
     cctest/test-macro-assembler-mips[64]/macro_float_minmax_f64
     mjsunit/regress/math-min
BUG=

Committed: https://crrev.com/e8f5adbed22c59a7df1530f4979768e6ebcda7c6
Cr-Commit-Position: refs/heads/master@{#41596}

[Ilija.Pavlovic1, 2016-12-07 14:35:13]

ilija.pavlovic@imgtec.com changed reviewers:
+ ivica.bogosavljevic@imgtec.com, miran.karic@imgtec.com

[Ilija.Pavlovic1, 2016-12-07 14:35:14]

PTAL

[miran.karic, 2016-12-07 14:47:49]

miran.karic@imgtec.com changed reviewers:
+ Miran.Karic@imgtec.com

[miran.karic, 2016-12-07 14:47:49]

lgtm

[Ilija.Pavlovic1, 2016-12-07 14:53:44]

The CQ bit was checked by ilija.pavlovic@imgtec.com

[commit-bot: I haz the power, 2016-12-07 14:53:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 14:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 14:57:44]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30161)

[ivica.bogosavljevic, 2016-12-07 14:59:15]

ivica.bogosavljevic@imgtec.com changed reviewers:
+ ilija.pavlovic@imgtec.com
- Ilija.Pavlovic@imgtec.com, Miran.Karic@imgtec.com

[ivica.bogosavljevic, 2016-12-07 14:59:16]

https://codereview.chromium.org/2556793003/diff/1/src/crankshaft/mips64/lithi...
File src/crankshaft/mips64/lithium-codegen-mips64.cc (right):

https://codereview.chromium.org/2556793003/diff/1/src/crankshaft/mips64/lithi...
src/crankshaft/mips64/lithium-codegen-mips64.cc:1890: if
(left_reg.is(right_reg)) {
can we move this check to Float64Max?

[ivica.bogosavljevic, 2016-12-07 15:05:04]

https://codereview.chromium.org/2556793003/diff/1/test/cctest/test-macro-asse...
File test/cctest/test-macro-assembler-mips64.cc (right):

https://codereview.chromium.org/2556793003/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips64.cc:2013: __ nop();
you shouldn't use b() outside of MacroAssembler, use Branch instead and you will
not need Nop

[Ilija.Pavlovic1, 2016-12-08 13:50:06]

ilija.pavlovic@imgtec.com changed reviewers:
+ marija.antic@imgtec.com

[Ilija.Pavlovic1, 2016-12-08 13:50:07]

https://codereview.chromium.org/2556793003/diff/1/src/crankshaft/mips64/lithi...
File src/crankshaft/mips64/lithium-codegen-mips64.cc (right):

https://codereview.chromium.org/2556793003/diff/1/src/crankshaft/mips64/lithi...
src/crankshaft/mips64/lithium-codegen-mips64.cc:1890: if
(left_reg.is(right_reg)) {
On 2016/12/07 14:59:15, ivica.bogosavljevic wrote:
> can we move this check to Float64Max?

Yes. Now, these checks are in Float(32|64)(Max|Min) functions.

Done.

https://codereview.chromium.org/2556793003/diff/1/test/cctest/test-macro-asse...
File test/cctest/test-macro-assembler-mips64.cc (right):

https://codereview.chromium.org/2556793003/diff/1/test/cctest/test-macro-asse...
test/cctest/test-macro-assembler-mips64.cc:2013: __ nop();
On 2016/12/07 15:05:04, ivica.bogosavljevic wrote:
> you shouldn't use b() outside of MacroAssembler, use Branch instead and you
will
> not need Nop

Using Branch macros will be applied also on macro-assembler-mips[64].cc files.

Done.

[Ilija.Pavlovic1, 2016-12-08 13:57:44]

PTAL

[ivica.bogosavljevic, 2016-12-08 14:16:03]

lgtm

[Ilija.Pavlovic1, 2016-12-08 14:31:08]

The CQ bit was checked by ilija.pavlovic@imgtec.com

[Ilija.Pavlovic1, 2016-12-08 14:31:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
Miran.Karic@imgtec.com
Link to the patchset: https://codereview.chromium.org/2556793003/#ps20001
(title: "Modified according comments.")

[commit-bot: I haz the power, 2016-12-08 14:31:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 14:56:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481207468174030,
"parent_rev": "0c5e49d8f5016b3595e914d4be98bbe5d2a6eb84", "commit_rev":
"2291197e40aa0f8b38b419a7d8f3d7a7f2f9bbdf"}

[commit-bot: I haz the power, 2016-12-08 14:57:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-08 14:57:10]

Description was changed from

==========
MIPS[64]: Fix `MIPS: Improve Float(32|64)(Max|Min)`.

Fix 7a6f294ffe8e9cc98e266238ec5cd0aa74524c4a.

The first correction enables correct execution DoMathMinMax when two
input registers are the same register.
The second correction adds NOP instructions after branch instructions
in tests macro_float_minmaxf(32|64).

TEST=cctest/test-macro-assembler-mips[64]/macro_float_minmax_f32
     cctest/test-macro-assembler-mips[64]/macro_float_minmax_f64
     mjsunit/regress/math-min
BUG=
==========

to

==========
MIPS[64]: Fix `MIPS: Improve Float(32|64)(Max|Min)`.

Fix 7a6f294ffe8e9cc98e266238ec5cd0aa74524c4a.

The first correction enables correct execution DoMathMinMax when two
input registers are the same register.
The second correction adds NOP instructions after branch instructions
in tests macro_float_minmaxf(32|64).

TEST=cctest/test-macro-assembler-mips[64]/macro_float_minmax_f32
     cctest/test-macro-assembler-mips[64]/macro_float_minmax_f64
     mjsunit/regress/math-min
BUG=

Committed: https://crrev.com/e8f5adbed22c59a7df1530f4979768e6ebcda7c6
Cr-Commit-Position: refs/heads/master@{#41596}
==========

[commit-bot: I haz the power, 2016-12-08 14:57:11]

Patchset 2 (id:??) landed as
https://crrev.com/e8f5adbed22c59a7df1530f4979768e6ebcda7c6
Cr-Commit-Position: refs/heads/master@{#41596}