android: Realign stack pointer on JNI entry.

android: Realign stack pointer on JNI entry.

M55 merge

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248, 672670
Review-Url: https://codereview.chromium.org/2531273002
Cr-Commit-Position: refs/heads/master@{#435632}
(cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602)

Committed: https://chromium.googlesource.com/chromium/src/+/01a46f06cc1a85d62abd4fd83e13ff3c07c91262
Committed: https://chromium.googlesource.com/chromium/src/+/366e9038733510ba1e448b056870d55a1b5d11a5

[amineer_google, 2016-12-09 03:12:38]

Description was changed from

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248

Review-Url: https://codereview.chromium.org/2531273002
Cr-Commit-Position: refs/heads/master@{#435632}
(cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602)
==========

to

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248

Review-Url: https://codereview.chromium.org/2531273002
Cr-Commit-Position: refs/heads/master@{#435632}
(cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602)
==========

[amineer_google, 2016-12-09 03:12:38]

amineer@google.com changed reviewers:
+ primiano@chromium.org, torne@chromium.org

[amineer, 2016-12-09 03:16:38]

Description was changed from

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248

Review-Url: https://codereview.chromium.org/2531273002
Cr-Commit-Position: refs/heads/master@{#435632}
(cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602)
==========

to

==========
android: Realign stack pointer on JNI entry.

M55 merge

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248,672670

Review-Url: https://codereview.chromium.org/2531273002
Cr-Commit-Position: refs/heads/master@{#435632}
(cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602)
==========

[amineer, 2016-12-09 03:22:58]

Description was changed from

==========
android: Realign stack pointer on JNI entry.

M55 merge

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248,672670

Review-Url: https://codereview.chromium.org/2531273002
Cr-Commit-Position: refs/heads/master@{#435632}
(cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602)
==========

to

==========
android: Realign stack pointer on JNI entry.

M55 merge

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248,672670

Review-Url: https://codereview.chromium.org/2531273002
Cr-Commit-Position: refs/heads/master@{#435632}
(cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602)

Committed:
https://chromium.googlesource.com/chromium/src/+/01a46f06cc1a85d62abd4fd83e13...
==========

[amineer, 2016-12-09 03:23:00]

Committed patchset #1 (id:1) manually as
01a46f06cc1a85d62abd4fd83e13ff3c07c91262.

[amineer, 2016-12-09 05:16:16]

Description was changed from

==========
android: Realign stack pointer on JNI entry.

M55 merge

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248,672670

Review-Url: https://codereview.chromium.org/2531273002
Cr-Commit-Position: refs/heads/master@{#435632}
(cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602)

Committed:
https://chromium.googlesource.com/chromium/src/+/01a46f06cc1a85d62abd4fd83e13...
==========

to

==========
android: Realign stack pointer on JNI entry.

M55 merge

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248,672670

Review-Url: https://codereview.chromium.org/2531273002
Cr-Commit-Position: refs/heads/master@{#435632}
(cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602)

Committed:
https://chromium.googlesource.com/chromium/src/+/01a46f06cc1a85d62abd4fd83e13...
Committed:
https://chromium.googlesource.com/chromium/src/+/366e9038733510ba1e448b056870...
==========

[amineer, 2016-12-09 05:16:18]

Committed patchset #1 (id:1) manually as
366e9038733510ba1e448b056870d55a1b5d11a5.