Reland: WebFonts cache-aware timeout adaptation

Reland: WebFonts cache-aware timeout adaptation

Suspicious root cause of the last revert was fixed. See crbug.com/670638.
Description from https://crrev.com/dc8303234f47ccfc841185d33c45e4852776b65e:

This CL introduces adaptive webfont display behavior, reducing unnecessary Flash
of Unstyled Text (FOUT) if webfont is already available in disk cache.  This is
available as a experimental Web Platform feature.

In webfont display, fallback font will be used if webfont loading time exceeds
certain timeout values in slow network. However it's observed that disk cache
RTT may also hit the timeout regardless of network speed. In such cases we would
like to block display until disk cache misses and actual network request is
being sent.

BUG=570205
TBR=isherman@chromium.org

Committed: https://crrev.com/1289bbe752b4d50eae1be6a3417537f801e5fdbc
Cr-Commit-Position: refs/heads/master@{#437522}

[Takashi Toyoshima, 2016-12-06 11:53:48]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 11:54:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2016-12-06 12:08:06]

Description was changed from

==========
Reland: WebFonts cache-aware timeout adaptation

Suspicious root cause of the last revert was fixed. See crbug.com/670638.
Description from https://crrev.com/dc8303234f47ccfc841185d33c45e4852776b65e:

This CL introduces adaptive webfont display behavior, reducing unnecessary Flash
of Unstyled Text (FOUT) if webfont is already available in disk cache.  This is
available as a experimental Web Platform feature.

In webfont display, fallback font will be used if webfont loading time exceeds
certain timeout values in slow network. However it's observed that disk cache
RTT may also hit the timeout regardless of network speed. In such cases we would
like to block display until disk cache misses and actual network request is
being sent.

BUG=570205
==========

to

==========
Reland: WebFonts cache-aware timeout adaptation

Suspicious root cause of the last revert was fixed. See crbug.com/670638.
Description from https://crrev.com/dc8303234f47ccfc841185d33c45e4852776b65e:

This CL introduces adaptive webfont display behavior, reducing unnecessary Flash
of Unstyled Text (FOUT) if webfont is already available in disk cache.  This is
available as a experimental Web Platform feature.

In webfont display, fallback font will be used if webfont loading time exceeds
certain timeout values in slow network. However it's observed that disk cache
RTT may also hit the timeout regardless of network speed. In such cases we would
like to block display until disk cache misses and actual network request is
being sent.

BUG=570205
==========

[Takashi Toyoshima, 2016-12-06 12:08:06]

toyoshim@chromium.org changed reviewers:
+ yhirano@chromium.org

[Takashi Toyoshima, 2016-12-06 12:08:59]

toyoshim@chromium.org changed reviewers:
+ isherman@chromium.org, tkent@chromium.org

[commit-bot: I haz the power, 2016-12-06 13:59:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 13:59:29]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2016-12-09 05:10:23]

ptal

[tkent, 2016-12-09 05:16:24]

lgtm

[yhirano, 2016-12-09 05:40:42]

lgtm

[Shao-Chuan Lee, 2016-12-09 06:33:51]

shaochuan@chromium.org changed reviewers:
+ shaochuan@chromium.org

[Shao-Chuan Lee, 2016-12-09 06:33:52]

https://codereview.chromium.org/2556683003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/resource/FontResource.cpp (right):

https://codereview.chromium.org/2556683003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/FontResource.cpp:194:
DCHECK(isLoading());
Should we make this consistent with fontLoadShortLimitCallback()?

[Takashi Toyoshima, 2016-12-09 10:28:20]

https://codereview.chromium.org/2556683003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/resource/FontResource.cpp (right):

https://codereview.chromium.org/2556683003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/FontResource.cpp:194:
DCHECK(isLoading());
Sorry for mixing new and old code in this CL.

Yeah, ShortLimig side was revised by another CL just now.
https://codereview.chromium.org/2558433002/

So, the next patch set should fix this issue through a rebase.

[Takashi Toyoshima, 2016-12-09 10:35:29]

Description was changed from

==========
Reland: WebFonts cache-aware timeout adaptation

Suspicious root cause of the last revert was fixed. See crbug.com/670638.
Description from https://crrev.com/dc8303234f47ccfc841185d33c45e4852776b65e:

This CL introduces adaptive webfont display behavior, reducing unnecessary Flash
of Unstyled Text (FOUT) if webfont is already available in disk cache.  This is
available as a experimental Web Platform feature.

In webfont display, fallback font will be used if webfont loading time exceeds
certain timeout values in slow network. However it's observed that disk cache
RTT may also hit the timeout regardless of network speed. In such cases we would
like to block display until disk cache misses and actual network request is
being sent.

BUG=570205
==========

to

==========
Reland: WebFonts cache-aware timeout adaptation

Suspicious root cause of the last revert was fixed. See crbug.com/670638.
Description from https://crrev.com/dc8303234f47ccfc841185d33c45e4852776b65e:

This CL introduces adaptive webfont display behavior, reducing unnecessary Flash
of Unstyled Text (FOUT) if webfont is already available in disk cache.  This is
available as a experimental Web Platform feature.

In webfont display, fallback font will be used if webfont loading time exceeds
certain timeout values in slow network. However it's observed that disk cache
RTT may also hit the timeout regardless of network speed. In such cases we would
like to block display until disk cache misses and actual network request is
being sent.

BUG=570205
TBR=isherman@chromium.org
==========

[Takashi Toyoshima, 2016-12-09 10:36:56]

I'd go with TBR=Ilya because this was already approved for the first submit, and
want to see what happens on Canary with this CL in this week end.

[Takashi Toyoshima, 2016-12-09 11:01:03]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-12-09 11:01:04]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2556683003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-09 11:01:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 12:44:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481281263616100,
"parent_rev": "25e7224049f2cd9d580ad02f48a61d7a412a9bad", "commit_rev":
"c28422b7807d6a71e922e08198b2ba0434d19f17"}

[commit-bot: I haz the power, 2016-12-09 12:45:17]

Description was changed from

==========
Reland: WebFonts cache-aware timeout adaptation

Suspicious root cause of the last revert was fixed. See crbug.com/670638.
Description from https://crrev.com/dc8303234f47ccfc841185d33c45e4852776b65e:

This CL introduces adaptive webfont display behavior, reducing unnecessary Flash
of Unstyled Text (FOUT) if webfont is already available in disk cache.  This is
available as a experimental Web Platform feature.

In webfont display, fallback font will be used if webfont loading time exceeds
certain timeout values in slow network. However it's observed that disk cache
RTT may also hit the timeout regardless of network speed. In such cases we would
like to block display until disk cache misses and actual network request is
being sent.

BUG=570205
TBR=isherman@chromium.org
==========

to

==========
Reland: WebFonts cache-aware timeout adaptation

Suspicious root cause of the last revert was fixed. See crbug.com/670638.
Description from https://crrev.com/dc8303234f47ccfc841185d33c45e4852776b65e:

This CL introduces adaptive webfont display behavior, reducing unnecessary Flash
of Unstyled Text (FOUT) if webfont is already available in disk cache.  This is
available as a experimental Web Platform feature.

In webfont display, fallback font will be used if webfont loading time exceeds
certain timeout values in slow network. However it's observed that disk cache
RTT may also hit the timeout regardless of network speed. In such cases we would
like to block display until disk cache misses and actual network request is
being sent.

BUG=570205
TBR=isherman@chromium.org

Review-Url: https://codereview.chromium.org/2556683003
==========

[commit-bot: I haz the power, 2016-12-09 12:45:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-09 12:47:34]

Description was changed from

==========
Reland: WebFonts cache-aware timeout adaptation

Suspicious root cause of the last revert was fixed. See crbug.com/670638.
Description from https://crrev.com/dc8303234f47ccfc841185d33c45e4852776b65e:

This CL introduces adaptive webfont display behavior, reducing unnecessary Flash
of Unstyled Text (FOUT) if webfont is already available in disk cache.  This is
available as a experimental Web Platform feature.

In webfont display, fallback font will be used if webfont loading time exceeds
certain timeout values in slow network. However it's observed that disk cache
RTT may also hit the timeout regardless of network speed. In such cases we would
like to block display until disk cache misses and actual network request is
being sent.

BUG=570205
TBR=isherman@chromium.org

Review-Url: https://codereview.chromium.org/2556683003
==========

to

==========
Reland: WebFonts cache-aware timeout adaptation

Suspicious root cause of the last revert was fixed. See crbug.com/670638.
Description from https://crrev.com/dc8303234f47ccfc841185d33c45e4852776b65e:

This CL introduces adaptive webfont display behavior, reducing unnecessary Flash
of Unstyled Text (FOUT) if webfont is already available in disk cache.  This is
available as a experimental Web Platform feature.

In webfont display, fallback font will be used if webfont loading time exceeds
certain timeout values in slow network. However it's observed that disk cache
RTT may also hit the timeout regardless of network speed. In such cases we would
like to block display until disk cache misses and actual network request is
being sent.

BUG=570205
TBR=isherman@chromium.org

Committed: https://crrev.com/1289bbe752b4d50eae1be6a3417537f801e5fdbc
Cr-Commit-Position: refs/heads/master@{#437522}
==========

[commit-bot: I haz the power, 2016-12-09 12:47:36]

Patchset 3 (id:??) landed as
https://crrev.com/1289bbe752b4d50eae1be6a3417537f801e5fdbc
Cr-Commit-Position: refs/heads/master@{#437522}

[Ilya Sherman, 2016-12-09 20:15:29]

RS LGTM for reland