Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2556633002: Revert of Paint collapsed borders of a table as one display item (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
chrishtr, esprehn, wkorman
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, leviw+renderwatch, mac-reviews_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Paint collapsed borders of a table as one display item (patchset #4 id:60001 of https://codereview.chromium.org/2502353003/ ) Reason for revert: Need to think more about performance and improve. Original issue's description: > Paint collapsed borders of a table as one display item > > This simplifies paint invalidation logic on collapsed border changes. > > About performance: > With this CL we create a big display item on the table containing all > collapsed border paintings, instead of many small display items on cells. > This will cause more painting when the display item is invalidated, but > saves time to handle many cached display items. Perf try jobs [1] show > that this CL improves performance of one test > (blink_perf.paint.large-table-background-change-with-visible-collapsed-borders.html), > and degrade performance of one test > (blink_perf.paint.large-table-repaint.html) > and doesn't affect much of performance of other tests. > Cluster-telemetry run showed no change or slight progression (https://ct.skia.org/chromium_perf_runs/, run 1433) > > This is a reland of https://codereview.chromium.org/2430313004, with > crbug.com/664887 fixed by force invalidation of collapsed borders on > layout change. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > BUG=663208, 664887 > TBR=chrishtr@chromium.org (for platform/graphics/paint/DisplayItem.h with changed display item types about collapsed borders) > > Review-Url: https://codereview.chromium.org/2430313004 > Committed: https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e > Cr-Original-Commit-Position: refs/heads/master@{#431744} > Cr-Commit-Position: refs/heads/master@{#436426} TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=663208, 664887 Committed: https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c Cr-Commit-Position: refs/heads/master@{#436484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+663 lines, -606 lines) Patch
M third_party/WebKit/LayoutTests/paint/invalidation/table-cell-collapsed-border-expected.txt View 2 chunks +42 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table-outer-border-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table-section-repaint-expected.txt View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/border-collapse-change-separate-to-collapse-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-cell-append-expected.txt View 2 chunks +16 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-cell-border-color-expected.txt View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-cell-border-width-expected.txt View 2 chunks +16 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-col-border-color-expected.txt View 2 chunks +14 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-col-border-width-expected.txt View 2 chunks +27 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-colgroup-border-color-expected.txt View 2 chunks +22 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-colgroup-border-width-expected.txt View 2 chunks +30 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-row-border-width-expected.txt View 3 chunks +19 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-table-border-color-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-table-border-width-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-tbody-border-width-expected.txt View 2 chunks +32 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize-expected.txt View 2 chunks +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color-expected.txt View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-cell-collapsed-border-expected.txt View 2 chunks +42 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-collapsed-border-expected.txt View 4 chunks +30 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table-collapsed-border-expected.txt View 4 chunks +30 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table-collapsed-border-expected.txt View 4 chunks +30 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 4 chunks +6 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 6 chunks +12 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 6 chunks +32 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 5 chunks +71 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCol.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.h View 3 chunks +5 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 4 chunks +50 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TablePainter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TablePainter.cpp View 1 chunk +19 lines, -49 lines 0 comments Download
D third_party/WebKit/Source/core/paint/TablePainterTest.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.h View 3 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.cpp View 3 chunks +8 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 2 chunks +22 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Xianzhu
Created Revert of Paint collapsed borders of a table as one display item
4 years ago (2016-12-06 02:17:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556633002/1
4 years ago (2016-12-06 02:18:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 02:21:32 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c Cr-Commit-Position: refs/heads/master@{#436484}
4 years ago (2016-12-06 02:24:23 UTC) #7
Adam Rice
4 years ago (2016-12-06 04:25:17 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2551963003/ by ricea@chromium.org.

The reason for reverting is: This revert seems to have broken
paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html 
and
virtual/spinvalidation/paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html
on many bots. Reverting some more just to be on the safe side.

See for example
https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trust....

Powered by Google App Engine
This is Rietveld 408576698