Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

Issue 2556633002: Revert of Paint collapsed borders of a table as one display item (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013
8 * Apple Inc. 8 * Apple Inc.
9 * All rights reserved. 9 * All rights reserved.
10 * 10 *
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 section()->rowLogicalHeightChanged(this); 67 section()->rowLogicalHeightChanged(this);
68 68
69 if (!parent()) 69 if (!parent())
70 return; 70 return;
71 LayoutTable* table = this->table(); 71 LayoutTable* table = this->table();
72 if (!table) 72 if (!table)
73 return; 73 return;
74 74
75 if (!table->selfNeedsLayout() && !table->normalChildNeedsLayout() && 75 if (!table->selfNeedsLayout() && !table->normalChildNeedsLayout() &&
76 oldStyle->border() != style()->border()) 76 oldStyle->border() != style()->border())
77 table->invalidateCollapsedBorders(PaintInvalidationStyleChange); 77 table->invalidateCollapsedBorders();
78 78
79 if (LayoutTableBoxComponent::doCellsHaveDirtyWidth(*this, *table, diff, 79 if (LayoutTableBoxComponent::doCellsHaveDirtyWidth(*this, *table, diff,
80 *oldStyle)) { 80 *oldStyle)) {
81 // If the border width changes on a row, we need to make sure the cells in 81 // If the border width changes on a row, we need to make sure the cells in
82 // the row know to lay out again. 82 // the row know to lay out again.
83 // This only happens when borders are collapsed, since they end up affecting 83 // This only happens when borders are collapsed, since they end up affecting
84 // the border sides of the cell itself. 84 // the border sides of the cell itself.
85 for (LayoutBox* childBox = firstChildBox(); childBox; 85 for (LayoutBox* childBox = firstChildBox(); childBox;
86 childBox = childBox->nextSiblingBox()) { 86 childBox = childBox->nextSiblingBox()) {
87 if (!childBox->isTableCell()) 87 if (!childBox->isTableCell())
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 // the visual overflow should be determined in the coordinate system of 307 // the visual overflow should be determined in the coordinate system of
308 // the row, that's why we shift it below. 308 // the row, that's why we shift it below.
309 LayoutUnit cellOffsetLogicalTopDifference = 309 LayoutUnit cellOffsetLogicalTopDifference =
310 cell->location().y() - location().y(); 310 cell->location().y() - location().y();
311 cellVisualOverflowRect.move(LayoutUnit(), cellOffsetLogicalTopDifference); 311 cellVisualOverflowRect.move(LayoutUnit(), cellOffsetLogicalTopDifference);
312 312
313 addContentsVisualOverflow(cellVisualOverflowRect); 313 addContentsVisualOverflow(cellVisualOverflowRect);
314 } 314 }
315 315
316 } // namespace blink 316 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableCol.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTableSection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698