Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Issue 2556613002: gn: Fix stale references in Parser::AssignComments(). (Closed)

Created:
4 years ago by viettrungluu
Modified:
4 years ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Fix stale references in Parser::AssignComments(). ParseNode::GetRange() returns a LocationRange (value, not reference), while LocationRange::begin() returns a const Location&. Initializing a local const Location& variable with that doesn't extend the lifetime of the temporary. Committed: https://crrev.com/d177088c55ef63ab7f28c34bdd124faf01adb389 Cr-Commit-Position: refs/heads/master@{#436637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/gn/parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
viettrungluu
4 years ago (2016-12-06 00:48:16 UTC) #3
brettw
lgtm
4 years ago (2016-12-06 04:38:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556613002/1
4 years ago (2016-12-06 17:40:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 17:53:43 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-06 17:55:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d177088c55ef63ab7f28c34bdd124faf01adb389
Cr-Commit-Position: refs/heads/master@{#436637}

Powered by Google App Engine
This is Rietveld 408576698